Closed
Bug 527201
Opened 15 years ago
Closed 11 years ago
Private MathML attributes should not be accessible from DOM
Categories
(Core :: MathML, defect, P5)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: fredw, Assigned: fredw)
References
Details
Attachments
(2 files, 2 obsolete files)
|
(deleted),
application/xhtml+xml
|
Details | |
|
(deleted),
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
MathML use several private attributes to implement "columnalign", "columnline", "rowalign", "rowline" (mtable attributes) and "fontstyle" (in particular to make <mi>x</mi> italic). They are used to apply CSS style via mathml.css. These attributes are currently accessible from DOM while they are not standard.
I try to fix bug 475518 to see whether following the right syntax _moz* helps, but apparently it does not work.
See also http://groups.google.fr/group/mozilla.dev.tech.mathml/browse_thread/thread/fd3e7defcdfb2b4f
|
Assignee | |
Comment 1•14 years ago
|
||
(In reply to comment #0)
> Created attachment 410943 [details]
> Testcase
It seems that this bug is fixed on trunk. At least, the private attributes are no longer caught by the testcase...
There are still 12 test cases in the html5lib test suite that show this problem. E.g. <!DOCTYPE html><body><table><math><mi>foo</mi></math></table>
Attaching a patch that reveals these when running
parser/htmlparser/tests/mochitest/test_html5_tree_construction_part2.html
|
|
Assignee | |
Comment 4•14 years ago
|
||
Update the reduced testcase.
Attachment #410943 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•12 years ago
|
||
(In reply to Frédéric Wang (:fredw) from comment #4)
> Created attachment 490486 [details]
> Testcase
>
> Update the reduced testcase.
Note: the test is not valid MathML because rowalign and columnalign attributes are reversed. But it detects the private _moz attributes anyway.
|
|
Assignee | |
Updated•12 years ago
|
Priority: -- → P5
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
Assignee | |
Comment 7•11 years ago
|
||
Attachment #490073 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•11 years ago
|
||
Comment on attachment 8347313 [details] [diff] [review]
Patch V2
After bugs 731667 and 114365, all the private _moz attributes have been removed. So I believe this patch can now be taken.
Attachment #8347313 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 9•11 years ago
|
||
Comment on attachment 8347313 [details] [diff] [review]
Patch V2
Awesome! Thank you.
Attachment #8347313 -
Flags: review?(hsivonen) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 11•11 years ago
|
||
|
|
||
Comment 12•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•