Max Kanat-Alexander Assignee
	Description • 15 years ago

Right now there's no space between the parameter section sortkeys, so you can't easily insert new modules in between them, in a hook or even during upstream development. Also, the sortkeys should be numeric instead of being strings.

The attached simple patch accomplishes this goal.

	Frédéric Buclin
	Comment 1 • 15 years ago

Comment on attachment 411112 [details] [diff] [review]
v1

>-$Bugzilla::Config::Attachment::sortkey = "025";
>+our $sortkey = 1600;

Attachment is between the old 02 and 03 sortkeys, so it shouldn't be moved to 1600, but rather 350 with your numbering.

	Max Kanat-Alexander Assignee
	Comment 2 • 15 years ago

Ah, thanks! :-)

	Frédéric Buclin
	Comment 3 • 15 years ago

Comment on attachment 411218 [details] [diff] [review]
v2

>=== modified file 'Bugzilla/Config/Attachment.pm'

>-$Bugzilla::Config::Attachment::sortkey = "025";
>+our $sortkey = 350;

While you are renumbering these sortkeys, you could use a rounded number for this file and shift subsequent sortkeys.



>=== modified file 'Bugzilla/Config/L10n.pm'

This file doesn't exist.

	Max Kanat-Alexander Assignee
	Comment 4 • 15 years ago

Fixed.

	Frédéric Buclin
	Comment 5 • 15 years ago

Comment on attachment 412944 [details] [diff] [review]
v3

r=LpSolit

	Max Kanat-Alexander Assignee
	Comment 6 • 15 years ago

Checking in Bugzilla/Config/Admin.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Admin.pm,v  <--  Admin.pm
new revision: 1.5; previous revision: 1.4
done
Checking in Bugzilla/Config/Attachment.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Attachment.pm,v  <--  Attachment.pm
new revision: 1.9; previous revision: 1.8
done
Checking in Bugzilla/Config/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Auth.pm,v  <--  Auth.pm
new revision: 1.5; previous revision: 1.4
done
Checking in Bugzilla/Config/BugChange.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/BugChange.pm,v  <--  BugChange.pm
new revision: 1.8; previous revision: 1.7
done
Checking in Bugzilla/Config/BugFields.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/BugFields.pm,v  <--  BugFields.pm
new revision: 1.8; previous revision: 1.7
done
Checking in Bugzilla/Config/BugMove.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/BugMove.pm,v  <--  BugMove.pm
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/Config/Core.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Core.pm,v  <--  Core.pm
new revision: 1.13; previous revision: 1.12
done
Checking in Bugzilla/Config/DependencyGraph.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/DependencyGraph.pm,v  <--  DependencyGraph.pm
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/Config/GroupSecurity.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/GroupSecurity.pm,v  <--  GroupSecurity.pm
new revision: 1.10; previous revision: 1.9
done
Checking in Bugzilla/Config/LDAP.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/LDAP.pm,v  <--  LDAP.pm
new revision: 1.3; previous revision: 1.2
done
Checking in Bugzilla/Config/MTA.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v  <--  MTA.pm
new revision: 1.18; previous revision: 1.17
done
Checking in Bugzilla/Config/PatchViewer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/PatchViewer.pm,v  <--  PatchViewer.pm
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/Config/Query.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Query.pm,v  <--  Query.pm
new revision: 1.8; previous revision: 1.7
done
Checking in Bugzilla/Config/RADIUS.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/RADIUS.pm,v  <--  RADIUS.pm
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/Config/ShadowDB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/ShadowDB.pm,v  <--  ShadowDB.pm
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/Config/UserMatch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/UserMatch.pm,v  <--  UserMatch.pm
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/params/editparams.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/editparams.html.tmpl,v  <--  editparams.html.tmpl
new revision: 1.9; previous revision: 1.8
done