Closed
Bug 527956
Opened 15 years ago
Closed 15 years ago
Performance Regression upgrading to SQLite 3.6.20
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
(deleted),
application/x-7z-compressed
|
Details |
Ts Shutdown MAX Dirty Profile regressed 0.94% on Leopard
Ts Shutdown MAX Dirty Profile regressed 3.09% on Linux
Windows showed no regression, and no other shutdown test showed a regression.
Assignee | ||
Comment 1•15 years ago
|
||
The database that is used can be found here (warnings, it's close to 200 MB):
http://files.shawnwilsher.com/2009/11/11/dirtyMaxDB.zip
Assignee | ||
Comment 2•15 years ago
|
||
Marco - was the log you generated based on this places.sqlite file?
Comment 3•15 years ago
|
||
no, it was based on a small profile, i can make one for this
Comment 4•15 years ago
|
||
Marco - In the previous log, host parameters in queries (ex: ?3) were replaced by the values actually bound to those parameters. However, the values replaced where not quoted. This caused invalid SQL, which we had to go in and hand-edit. Is there any easy fix for this, or is it something we'll just have to work around?
Comment 5•15 years ago
|
||
the log was just generated through a stupid script using storage prlog data (with some custom addition), so that was a blind find and replace (some param could be weird, especially those binded through name could have a bad replace ordering).
i can fix that though, if you need to change the log data should not be a problem, i'll generate a new one with the above db and quoted string params.
Comment 6•15 years ago
|
||
this is a 200MB txt log with quoted params... good luck :\
Updated•15 years ago
|
Attachment #412204 -
Attachment is patch: false
Attachment #412204 -
Attachment mime type: text/plain → application/octet-stream
Updated•15 years ago
|
Attachment #412204 -
Attachment mime type: application/octet-stream → application/x-7z-compressed
Assignee | ||
Updated•15 years ago
|
Depends on: SQLite3.6.22
Assignee | ||
Comment 7•15 years ago
|
||
Looking at the graphs, I think the upgrade killed these two regressions. The automatic scripts haven't shown anything yet though...
Assignee | ||
Comment 8•15 years ago
|
||
Now we are talking!
Ts Shutdown, MAX Dirty Profile decrease 7.85% on Linux Firefox
Before the regression, it was at 6253.42 (raised to 6446.89). After the upgrade, it ended up at 5965.58 (from 6473.79). I'd say this is fixed, with room to spare on Linux. We'll see if the scripts notice anything on Leopard.
Assignee | ||
Comment 9•15 years ago
|
||
Ts Shutdown, MAX Dirty Profile decrease 4.84% on Leopard Firefox
Before the regression, it was at 6943.47 (raise to 7008.68). After the upgrade, it ended up at 6886.95 (from 6553.63). This bug is now fixed.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•