Closed
Bug 528082
Opened 15 years ago
Closed 15 years ago
"Assertion failure: cg->lexdeps.lookup(atom), at ../jsemit.cpp"
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta5-fixed |
People
(Reporter: gkw, Assigned: brendan)
References
Details
(Keywords: assertion, regression, testcase, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
function spaces(n)
{
if (n == 0) return "";
if (n == 1) return " ";
var w = spaces(Math.floor(n/2));
return w + w + spaces(n%2);
}
var s = "<a b={\n1} />;/**/(((function c() {c}) for(d in [])))";
s = s.replace("/**/", "/*" + spaces(228) + "*/");
eval(s);
asserts js debug shell at Assertion failure: cg->lexdeps.lookup(atom), at ../jsemit.cpp:2195 without -j on TM tip. It used to assert at Assertion failure: cg->upvars.lookup(atom), at ../jsemit.cpp:2033 as one bisects back in time.
Many thanks to Jesse for helping to reduce this testcase.
autoBisect shows this is probably related to bug 452498:
The first bad revision is:
changeset: 26784:2cf0bbe3772a
user: Brendan Eich
date: Sun Apr 05 21:17:22 2009 -0700
summary: upvar2, aka the big one take 2 (452498, r=mrbkap).
Flags: blocking1.9.2?
Comment 1•15 years ago
|
||
Added bug 527032 to the see also list, as it's also implicated as an upvar2 regression.
Updated•15 years ago
|
Flags: wanted1.9.2+
Flags: blocking1.9.2?
Flags: blocking1.9.2-
Assignee | ||
Comment 2•15 years ago
|
||
New js/src/tests/ecma_3/FunExpr/regress-528082.js addition to cover the bug underlying the botched assertion.
/be
Assignee | ||
Comment 3•15 years ago
|
||
This bug could already be causing some woes in a release build, as the reference to the enclosing named lambda could get undefined or some random upvar (arg or stack local) slot instead of the denoted function object. Strongly suggest we take for 1.9.2.
QA folks if you have any mystery bugs (I have seen a few lately), esp. ones pinned on upvar, please try this patch.
/be
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.3a1
Updated•15 years ago
|
Attachment #413402 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 4•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/8808e68c71df
Comment 3 missed beltzner's fine comment 1, which cites bug 527032 as another upvar2 regression. Does the patch I just landed on tm fix 527032?
/be
Whiteboard: fixed-in-tracemonkey
Assignee | ||
Updated•15 years ago
|
Flags: blocking1.9.2- → blocking1.9.2?
Priority: -- → P1
Updated•15 years ago
|
Flags: blocking1.9.2? → blocking1.9.2+
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 6•15 years ago
|
||
status1.9.2:
--- → final-fixed
Comment 7•12 years ago
|
||
A testcase for this bug was automatically identified at js/src/tests/ecma_3/FunExpr/regress-528082.js.
Flags: in-testsuite+
Reporter | ||
Comment 8•12 years ago
|
||
Testcases have been landed by virtue of being marked in-testsuite+ -> VERIFIED as well.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•