Closed
Bug 528134
Opened 15 years ago
Closed 15 years ago
inDOMUtils::GetRuleNodeForContent can hand back a dead rulenode
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta5-fixed |
| blocking1.9.1 | --- | .8+ |
| status1.9.1 | --- | .8-fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: crash, fixed1.9.0.18, Whiteboard: [sg:critical?])
Attachments
(3 files)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
approval1.9.2+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
dbaron
:
review+
dveditz
:
approval1.9.1.8+
dveditz
:
approval1.9.0.18+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
See bug 527567 comment 5.
|
Assignee | |
Comment 1•15 years ago
|
||
Zack, do you prefer r=zwol, or r=zweinberg, or something else?
|
||
Comment 2•15 years ago
|
||
A bunch of tabs snuck in to that patch (making the lines look misindented).
|
|
Assignee | |
Comment 3•15 years ago
|
||
Good catch. Fixed locally.
|
||
Updated•15 years ago
|
Whiteboard: [sg:critical?]
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 411888 [details] [diff] [review]
Fix
r=dbaron
We should really get this in on 1.9.2...
Attachment #411888 -
Flags: review?(zweinberg) → review+
|
|
||
Updated•15 years ago
|
Flags: blocking1.9.2?
Flags: blocking1.9.2? → blocking1.9.2+
Whiteboard: [sg:critical?] → [sg:critical?][needs landing][needs 192 landing]
|
|
||
Updated•15 years ago
|
Attachment #411888 -
Flags: approval1.9.2+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Whiteboard: [sg:critical?][needs landing][needs 192 landing] → [sg:critical?][needs 192 landing]
|
|
Assignee | |
Comment 6•15 years ago
|
||
status1.9.2:
--- → final-fixed
Whiteboard: [sg:critical?][needs 192 landing] → [sg:critical?]
|
|
Assignee | |
Comment 7•15 years ago
|
||
Applies on 1.9.0 with -F3.
Attachment #414451 -
Flags: review?(dbaron)
|
|
||
Comment 8•15 years ago
|
||
Comment on attachment 414451 [details] [diff] [review]
1.9.1/1.9.0 merge
r=dbaron
Attachment #414451 -
Flags: review?(dbaron) → review+
|
||
Updated•15 years ago
|
|
||
Comment 9•15 years ago
|
||
These bugs landed after b4 was cut. Moving flag out.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #414451 -
Flags: approval1.9.1.7?
Attachment #414451 -
Flags: approval1.9.0.17?
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
|
|
||
Comment 11•15 years ago
|
||
Comment on attachment 414451 [details] [diff] [review]
1.9.1/1.9.0 merge
Approved for 1.9.1.7 and 1.9.0.17, a=dveditz for release-drivers
Attachment #414451 -
Flags: approval1.9.1.7?
Attachment #414451 -
Flags: approval1.9.1.7+
Attachment #414451 -
Flags: approval1.9.0.17?
Attachment #414451 -
Flags: approval1.9.0.17+
|
|
Assignee | |
Comment 13•15 years ago
|
||
Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/35d5359743c3
Checked into CVS:
Checking in layout/inspector/src/inDOMUtils.cpp;
/cvsroot/mozilla/layout/inspector/src/inDOMUtils.cpp,v <-- inDOMUtils.cpp
new revision: 1.42; previous revision: 1.41
done
Checking in layout/inspector/src/inDOMUtils.h;
/cvsroot/mozilla/layout/inspector/src/inDOMUtils.h,v <-- inDOMUtils.h
new revision: 1.13; previous revision: 1.12
done
Checking in layout/style/nsIInspectorCSSUtils.h;
/cvsroot/mozilla/layout/style/nsIInspectorCSSUtils.h,v <-- nsIInspectorCSSUtils.h
new revision: 1.12; previous revision: 1.11
done
Checking in layout/style/nsInspectorCSSUtils.cpp;
/cvsroot/mozilla/layout/style/nsInspectorCSSUtils.cpp,v <-- nsInspectorCSSUtils.cpp
new revision: 1.37; previous revision: 1.36
done
Checking in layout/style/nsInspectorCSSUtils.h;
/cvsroot/mozilla/layout/style/nsInspectorCSSUtils.h,v <-- nsInspectorCSSUtils.h
new revision: 1.13; previous revision: 1.12
Keywords: fixed1.9.0.17
|
||
Comment 14•15 years ago
|
||
|
||
Comment 15•15 years ago
|
||
David or Boris, how can QA verify this fix? For the given signature in the summary no crashes are listed at all. For which signature I would have to search?
Target Milestone: --- → mozilla1.9.3a1
|
|
Assignee | |
Comment 16•15 years ago
|
||
See bug 527567.
|
|
||
Comment 17•15 years ago
|
||
(In reply to comment #16)
> See bug 527567.
I'm not able to reproduce the crash with an 3.5.7 build and the Google Page Speed addon installed. Looks like we have to wait for the beta cycle or the release to check the crash stats.
|
|
||
Comment 18•15 years ago
|
||
It should be hard to reproduce without frame poisoning.
|
|
||
Updated•15 years ago
|
Group: core-security
You need to log in
before you can comment on or make changes to this bug.
Description
•