Closed
Bug 529356
Opened 15 years ago
Closed 15 years ago
Fix un-handled switch cases in nsStyleAnimation's "StyleCoordToValue" helper function
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Currently I get this build warning when building mozilla-central:
> ../../../mozilla/layout/style/nsStyleAnimation.cpp:950: warning: enumeration value ‘eStyleUnit_Degree’ not handled in switch
> ../../../mozilla/layout/style/nsStyleAnimation.cpp:950: warning: enumeration value ‘eStyleUnit_Grad’ not handled in switch
> ../../../mozilla/layout/style/nsStyleAnimation.cpp:950: warning: enumeration value ‘eStyleUnit_Radian’ not handled in switch
I think we just need to add a "default" case to that function, which should return PR_FALSE (indicating that we failed to convert the degree/grad/radian-unitted nsStyleCoord into a nsStyleAnimation::Value)
|
Assignee | |
Comment 1•15 years ago
|
||
|
||
Comment 2•15 years ago
|
||
Comment on attachment 412917 [details] [diff] [review]
fix: add 'default' case in StyleCoordToValue
r=dbaron
Attachment #412917 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
Blocks: css-transitions
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [build_warning]
You need to log in
before you can comment on or make changes to this bug.
Description
•