Closed
Bug 530352
Opened 15 years ago
Closed 12 years ago
Eliminate last nsFileSpec and nsIFileSpec (references) from Core
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: sgautherie, Assigned: Cykesiopka)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
This bug is for the comments (and maybe related code) only:
{
/parser/htmlparser/tests/outsinks/Convert.cpp
* line 62 -- // until I find out how to use nsFileSpec:
* line 285 -- // until I find out how to use nsFileSpec:
/widget/src/xpwidgets/nsTransferable.cpp
* line 89 -- //nsIFileSpec * cacheFile = GetFileSpec(mCacheFileName);
/extensions/java/xpcom/interfaces/Makefile.in
* line 107 -- # interface nsIFileSpec.
}
There seems to be only one last trace of this:
http://mxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsTransferable.cpp#90
Should the comment just be removed?
Component: General → XP Toolkit/Widgets: XUL
QA Contact: general → xptoolkit.xul
|
Reporter | |
Comment 2•13 years ago
|
||
(In reply to :aceman from comment #1)
> Should the comment just be removed?
Most likely. Or reviewer should hint to which replacement code he would like instead.
|
Assignee | |
Updated•12 years ago
|
Flags: needinfo?(vladimir)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Don't know if this is what is desired, but I already made the patch...
Attachment #738832 -
Flags: review?(vladimir)
Attachment #738832 -
Flags: review?(vladimir) → review+
|
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → cykesiopka
QA Contact: cykesiopka
|
||
Comment 5•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
||
Comment 7•7 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•