Closed
Bug 530554
Opened 15 years ago
Closed 15 years ago
[mozmill] Fix broken testCheckMSN.js: subject is null
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Tobbi, Assigned: Tobbi)
References
Details
(Keywords: regression, Whiteboard: [mozmill-test-failure])
Attachments
(1 file)
(deleted),
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
When running testCheckMSN.js , a 'subject is null' exception is thrown in testCheckMSN.js on line 65:
// Image has to be loaded first
controller.waitForEval("subject.complete === true", gTimeout, 100, img.getNode());
Comment 1•15 years ago
|
||
Should this bug be in Testing::Mozmill rather than Core::Layout?
Comment 2•15 years ago
|
||
This is a test and not a Mozmill specific issue. Given that we track all tests in the appropriate component we are doing the same for Mozmill tests for nearly one year now. David, just ignore bugs with the prefix [mozmill] if you are not interested in.
(In reply to comment #2)
> This is a test and not a Mozmill specific issue. Given that we track all tests
> in the appropriate component we are doing the same for Mozmill tests for nearly
> one year now. David, just ignore bugs with the prefix [mozmill] if you are not
> interested in.
I think David's original concern here is that this bug doesn't have enough data in it for anyone to do anything actionable to fix it. What's the issue here and what is the necessary action that needs to be taken to resolve it. Why is this a layout issue? Every layout bug needs a concrete set of steps to reproduce and a clear indication of why you believe the layout is broken.
Comment 4•15 years ago
|
||
(In reply to comment #3)
> I think David's original concern here is that this bug doesn't have enough data
> in it for anyone to do anything actionable to fix it. What's the issue here
Why not? It has everything we need to fix the Mozmill test.
> and what is the necessary action that needs to be taken to resolve it. Why is
> this a layout issue? Every layout bug needs a concrete set of steps to
> reproduce and a clear indication of why you believe the layout is broken.
We are talking about a test and not a layout bug. If a reftest is failing it's also filed under layout with the errors as comment. It's the same as we have here.
If we need a further discussion we should move it elsewhere but not adding more off-topic content here.
Tobias, would you mind to create a patch too? It looks like that the image we are looking for doesn't exist anymore or we have a problem with a redirect depending on your used locale build. We should check that first.
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → tobbi.bugs
Status: NEW → ASSIGNED
Comment 6•15 years ago
|
||
Comment on attachment 414237 [details] [diff] [review]
fixing img not found in code
Looks good!
Attachment #414237 -
Flags: review?(hskupin) → review+
Comment 7•15 years ago
|
||
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/623bfcf65dde
http://hg.mozilla.org/qa/mozmill-tests/rev/276903ed6808
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Keywords: regression
Updated•15 years ago
|
Whiteboard: [mozmill-test-failure]
Comment 8•14 years ago
|
||
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Layout → Mozmill Tests
Product: Core → Mozilla QA
QA Contact: layout → mozmill-tests
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•