Closed
Bug 531163
Opened 15 years ago
Closed 14 years ago
[mozmill] testGetAddons.js is locale-dependent, fails on non-English versions of Firefox
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Tobbi, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
In testGetAddons.js the labels on the add-on manager are hardcoded:
===
// Verify elements of the addon manager are visible
var panes = [
{button: "search-view", label:"Get Add-ons"},
{button: "extensions-view", label:"Extensions"},
{button: "themes-view", label:"Themes"},
{button: "plugins-view", label:"Plugins"}
];
===
This results in the following Mozmill error:
fail :: Controller.assertProperty() failed
message: Controller.assertProperty() failed
fileName: file:///C:/Users/Tobi/AppData/Roaming/Mozilla/Firefox/Profiles/sb05ameh.QA%20Mozmill%20Test/extensions/mozmill@mozilla.com/resource/modules/controller.js
lineNumber: 760
This should be changed as the test only passes on English versions of Firefox!
Reporter | ||
Comment 1•15 years ago
|
||
Comment 3•15 years ago
|
||
Comment on attachment 414760 [details] [diff] [review]
fixing whitespaces
I will move the comment right before the line of code which fails. That makes it more discoverable.
Attachment #414760 -
Flags: review+
Comment 4•15 years ago
|
||
Comment has been landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/28b3ea6d7d59
http://hg.mozilla.org/qa/mozmill-tests/rev/4a47ee24a710
I'll leave that bug open for a final fix once reading DTD files is possible.
Depends on: 504635
Comment 5•14 years ago
|
||
We do not reference the panes anymore via the label but via their id. Lets call it fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Component: Add-ons Manager → Mozmill Tests
Product: Toolkit → Testing
QA Contact: add-ons.manager → mozmilltests
Comment 6•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•