Closed
Bug 531361
Opened 15 years ago
Closed 15 years ago
Line layout should not assert about long lines that may occur naturally
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: hsivonen, Assigned: roc)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce:
1) Enable the HTML5 parser.
2) Use a debug build. (I had fixes for bug 509009 and bug 502804 applied.)
3) Load https://www.mybroadview.com/Pages/Login.aspx
Actual results:
Lots of asserts in
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsLineLayout.cpp#180
NS_NOTREACHED("bad width");
in nsLineLayout::BeginLineReflow.
Expected results:
Expected behavior that does not break into debugger when XPCOM_DEBUG_BREAK=trap.
|
Assignee | |
Comment 1•15 years ago
|
||
500,000 appunits was only a bit over 8000 CSS pixels, which isn't hard to hit.
One million CSS pixels is about 265 metres normally, which is a bit more ridiculous.
We should also remove NOTREACHED since Web content can hit whatever limit we set.
Assignee: nobody → roc
Attachment #414815 -
Flags: review?(dbaron)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 414815 [details] [diff] [review]
fix
r=dbaron
Attachment #414815 -
Flags: review?(dbaron) → review+
|
|
||
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•