Closed
Bug 534523
Opened 15 years ago
Closed 14 years ago
Move to / Copy to Recent context submenu list doesn't sort folder names alphabetically [v3.0 regression]
Categories
(Thunderbird :: Folder and Message Lists, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Thunderbird 3.3a2
People
(Reporter: jhframe, Assigned: bwinton)
References
()
Details
(Keywords: regression, Whiteboard: [gs][needs regression range])
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Bienvenu
:
review+
clarkbw
:
ui-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0
The Move to Recent and Copy to Recent context submenu displays a list of most recently used folders. However, the folder list is not sorted alphabetically. (It might be sorted by most recently accessed, but if so the sort operation appears to include folders used by Thunderbird in its own actions, as in my installation the Junk and Inbox folders are always present in the list, despite the fact that I never manually move messages to them.) The absence of alpha sorting makes finding the desired folder name very tedious. This behavior is different from Thunderbird 2, in which alpha sorting was the norm.
Reproducible: Always
Steps to Reproduce:
1. Right-click on a message in the folder list.
2. Expand the Move to / Recent or Copy to / Recent submenu to reveal the list
3. Observe the absence of alpha sorting in the list.
Actual Results:
Observe the Recent list sorted by some means other than alphabetically.
Expected Results:
The list should be sorted in alphabetical order, or an option provided to control the manner in which the list is sorted.
Comment 1•15 years ago
|
||
Summary: Move to / Copy to Recent context submenu list doesn't sort alphabetically. → Move to / Copy to Recent context submenu list doesn't sort folder names alphabetically.
Comment 2•15 years ago
|
||
indeed, this is a regression. v2 folder list had special folders at the top, and remaining folders alphabetical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Windows XP → All
Version: unspecified → 3.0
Updated•15 years ago
|
Whiteboard: [gs]
Comment 3•15 years ago
|
||
what will help is for someone to hunt with big game guns for the regression range. see bug 551137 comment 2 for regression range hunting hints. One possible time frame to hunt is around when de-rdf bug 414038 landed circa 2008-11-12.
other *regression* "recent folder" bugs:
https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=anywordssubstr&emailreporter1=1&emailcc1=1&short_desc=recent%20folder&field0-0-0=short_desc&bug_severity=major&bug_severity=normal&bug_severity=minor&bug_severity=enhancement&field1-0-2=keywords&type1-0-1=substring&value1-0-1=regression&classification=Client%20Software&classification=Components&type1-0-2=substring&emailtype1=substring&value1-0-2=regression&chfieldto=Now&query_format=advanced&chfieldfrom=2008-01-01&value1-0-0=regression&short_desc_type=allwordssubstr&email1=vseerror%40lehigh.edu&type0-0-0=nowords&value0-0-0=count%20counts&field1-0-0=short_desc&product=MailNews%20Core&product=Thunderbird&field1-0-1=status_whiteboard
Keywords: regressionwindow-wanted
Whiteboard: [gs] → [gs][needs regression range]
Comment 6•14 years ago
|
||
For the record, in Bug 551136 I'm talking about the "Recent Folders" pane
at the left side (selected by the little arrows from "All Folders"), not
the "Recent" list in the Move/Copy. The latter seems to be an entirely
different list -- much shorter, and much older access by date, with none
of the blue highlighted folders in it!
Moreover, my Move/Copy Recent list has entries at the bottom that haven't
been touched for over a year (according to the file dates), and are not
in the "Recent Folders" pane.
Finally, my Move/Copy Recent list has only 15 entries, while my "Recent
Folders" list has mostly different entries, including the folder that's
populated by bugzilla messages (now at the top).
Comment 7•14 years ago
|
||
Here is a picture showing both forms of Recent folders. Note that they
don't match each other, neither is sorted in the same order, and they
don't have most of the 26 recently downloaded folders.
(Private emails blanked.)
SO, a YEAR later, is it so difficult to simply revert to the v2.x.x logic, where IT WORKED?
Assignee | ||
Comment 9•14 years ago
|
||
Assignee | ||
Comment 10•14 years ago
|
||
I almost hate to work on this, lest people think that they can get results by complaining, but it has been bothering me for a while, and I did touch this code in the not too distant past, so here's a patch that alphabetizes the recent folders before displaying them.
Later,
Blake.
Attachment #498773 -
Flags: ui-review?(clarkbw)
Attachment #498773 -
Flags: review?(bienvenu)
Comment 11•14 years ago
|
||
Thank you. Seriously and sincerely. Now, how and to what does one apply the patch?
Assignee | ||
Comment 12•14 years ago
|
||
You would apply it to http://hg.mozilla.org/comm-central/ (In theory, anyways. I've actually developed it on comm-central rev 42371756f234, and mozilla-central rev cdb7dae6fdbb.)
Also, just as an fyi, reverting really would be that difficult, because the bit of code that handles the folder popups (and recent folder mode) has been completely rewritten since Thunderbird 2.x, in an incompatible (but much easier to work with) way.
Later,
Blake.
Comment 13•14 years ago
|
||
Comment on attachment 498773 [details] [diff] [review]
A patch to sort the two recent folder lists alphabetically.
Yeah, that's cleaner. Thanks Blake! You are a warrior :)
Attachment #498773 -
Flags: ui-review?(clarkbw) → ui-review+
Comment 14•14 years ago
|
||
Comment on attachment 498773 [details] [diff] [review]
A patch to sort the two recent folder lists alphabetically.
this is not working for me at all - I don't know if it's a build issue or what...
Updated•14 years ago
|
Attachment #498773 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 15•14 years ago
|
||
In the interests of my actually taking a vacation, I'm going to mark this checkin-needed, instead of checking it in and having to watch the tree myself. ;)
It also needs tests, which I'll probably write in the new year.
Thanks,
Blake.
Comment 16•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
Comment 17•14 years ago
|
||
appears to be working in current trunk.
Status: RESOLVED → VERIFIED
Summary: Move to / Copy to Recent context submenu list doesn't sort folder names alphabetically. → Move to / Copy to Recent context submenu list doesn't sort folder names alphabetically [v3.0 regression]
Updated•9 years ago
|
Keywords: regressionwindow-wanted
You need to log in
before you can comment on or make changes to this bug.
Description
•