Closed Bug 534781 Opened 15 years ago Closed 15 years ago

Testsuite: base64-encode atob() is broken

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(thunderbird3.0 .5-fixed)

RESOLVED FIXED
Thunderbird 3.1b1
Tracking Status
thunderbird3.0 --- .5-fixed

People

(Reporter: BenB, Assigned: BenB)

References

Details

Attachments

(1 file)

atob() (base64-encode) in mailnews/test/resources/mailTestUtils.js is broken (btoa() works): atob(btoa(plain)) == plain fails with "116101115116116101115116116101115116" != "testtesttest" Attaching fix. Thanks to jcranmer (author) for the pointer.
Attached patch Fix, v1 (deleted) — Splinter Review
Attachment #417599 - Flags: review?(Pidgeot18)
Comment on attachment 417599 [details] [diff] [review] Fix, v1 standard8, please r and/or sr. Should be straight-forward.
Attachment #417599 - Flags: superreview?(bugzilla)
Comment on attachment 417599 [details] [diff] [review] Fix, v1 If it works...
Attachment #417599 - Flags: review?(Pidgeot18) → review+
Attachment #417599 - Flags: superreview?(bugzilla) → superreview+
remind self: commit
Commited to comm-central trunk: <http://hg.mozilla.org/comm-central/rev/69c6658a1102> FIXED
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Target Milestone: --- → Thunderbird 3.1b1
Version: 1.9.1 Branch → Trunk
Comment on attachment 417599 [details] [diff] [review] Fix, v1 Although we're not really dependent on this on the 3.0.x branch at the moment, I'd feel safer for taking it onto that branch in case a test relies on it later.
Attachment #417599 - Flags: approval-thunderbird3.0.5+
Verifying on 3.0 as the patch has landed on branch and the tests are passing (plus this is a test-only bug).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: