Closed Bug 535691 Opened 15 years ago Closed 14 years ago

"ASSERTION: unknown nsISVGValue" with animateTransform

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Unassigned)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached image testcase (deleted) —
###!!! ASSERTION: unknown nsISVGValue: 'Not Reached', file /Users/jruderman/mozilla-central/content/svg/content/src/nsSVGElement.cpp, line 969
This is WORKSFORME in a Linux debug build from today. I get this output at pageload: { nsSVGStringProxyValue CTOR nsSVGStringProxyValue(0xaf971b40)::SetValueString(10 20) -> call failed, now using cached value } but no assertion failures. Jesse, mind verifying?
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
(In reply to comment #1) > nsSVGStringProxyValue CTOR > nsSVGStringProxyValue(0xaf971b40)::SetValueString(10 20) > -> call failed, now using cached value FWIW, this appears to be non-scary output, from glancing at the source: http://mxr.mozilla.org/mozilla-central/source/content/svg/content/src/nsSVGStringProxyValue.cpp#112 http://mxr.mozilla.org/mozilla-central/source/content/svg/content/src/nsSVGStringProxyValue.cpp#150
(see also Bug 556808, for another instance of this "unknown nsISVGValue" assertion failure.)
Yeah, WFM. I'll add this as a crashtest.
Flags: in-testsuite+
The patch for bug 552938 regresses this. Why might that be?
I can't reproduce the problem on either Mac 32-bit or Linux 64-bit. How should I proceed with the patch for bug 552938? Would it be too inappropriate to land it and reopen this bug?
I don't get any asserts on Windows with the testcase with your patch from bug 552938.
I wouldn't especially mind. Be sure to add asserts(0-1) or asserts(1) to the crashtest manifest so you don't turn the tree orange.
Comment on attachment 449588 [details] [diff] [review] Add an assertion annotation I take it the assertion can happen up to twice? Please add a comment on the line pointing back to this bug, so we're more likely to remember to remove the asserts() if this bug becomes WFM again: +asserts(0-2) load 535691-1.svg # bug 535691 Btw, if a stack trace from Try would help you figure out why this happens, you can push your patch for bug 552938 with my patch for bug 570287.
Attachment #449588 - Flags: review?(jruderman) → review+
(In reply to comment #11) > (From update of attachment 449588 [details] [diff] [review]) > I take it the assertion can happen up to twice? > > Please add a comment on the line pointing back to this bug, so we're more > likely to remember to remove the asserts() if this bug becomes WFM again: > > +asserts(0-2) load 535691-1.svg # bug 535691 Thanks. Landed with the comment: http://hg.mozilla.org/mozilla-central/rev/d36a5c77457f > Btw, if a stack trace from Try would help you figure out why this happens, you > can push your patch for bug 552938 with my patch for bug 570287. OK. Thanks.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
This should now be fixed by bug 603917, specifically changeset http://hg.mozilla.org/mozilla-central/rev/4e06966e8dfe I'll wait to check that everything is fine on tinderbox (TryServer was all good) and, unless there are any objections, mark this fixed.
Depends on: 603917
Status: REOPENED → RESOLVED
Closed: 15 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: