User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.6) Gecko/20091201 Firefox/3.5.6 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.6) Gecko/20091201 Firefox/3.5.6 While compiling mozilla-central/toolkit/mozapps/update/src/updater/updater.cpp on AIX, getting below compilation error - "mozilla-central/toolkit/mozapps/update/src/updater/updater.cpp", line 553.30: 1540-0202 (S) An expression of type "AutoFile" is not allowed on the left side of "->". "mozilla-central/toolkit/mozapps/update/src/updater/updater.cpp", line 1795.14: 1540-0202 (S) An expression of type "AutoFile" is not allowed on the left side of "->". Reproducible: Always Steps to Reproduce: 1. Build Mozilla Firefox 3.7a1pre build on AIX with Gnome RPMS of 64 bit version. 2. 3. Actual Results: Build fails with the above error. Expected Results: No build failure

This patch resolves the compiler error on AIX

This bug also occurs on FreeBSD 7.2, and the proposed patch resolves it, as well.

Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/42e7756b93a2

Fix hasn't landed on 1.9.2 branch yet 1.9.1 is not affected

Is there a distribution that actually needs this and if there is please provide a link to it. Thanks

IBM's outdated release 3.5.8 here for AIX 5.3 64bit only: <http://www-03.ibm.com/systems/power/software/aix/browsers/> My builds for AIX 5.1 and 32bit which runs on much more machines <http://www.linkitup.de/ForAIX/Firefox> And yesterday the very first successfull build of Firefox 3.6.13 was finished. Still testing, not published yet. <http://home.arcor.de/linkitup/ForAIX/SeaMonkey/firefox-3.6.13-4.aix5.3.ppc.rpm>

Comment on attachment 497151 [details] [diff] [review] same fix adjusted for 1.9.2 branch Thank you very much for the info. I have a couple of patches against the updater that have already been approved for 1.9.2 and will check this in as well when it gets approved. Drivers, I'd like to get this for 1.9.2

Comment on attachment 497151 [details] [diff] [review] same fix adjusted for 1.9.2 branch a=LegNeato for 1.9.2.14

Pushed to mozilla-1.9.2 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/13d03f2a70c3

btw: if you choose to use a different update mechanism such as a package management app then it is better to compile with ac_add_options --disable-updater This will remove Help -> Check For Updates / the UI for the preferences / etc. and not load the app update components which should improve startup time slightly.

(In reply to comment #11) > btw: if you choose to use a different update mechanism such as a package > management app then it is better to compile with > ac_add_options --disable-updater > > This will remove Help -> Check For Updates / the UI for the preferences / etc. > and not load the app update components which should improve startup time > slightly. rstrong: thx for your very fast response and pointing me to --disable-updater configure flag. Will use it in my mozconfig from now.

Backed out of 1.9.2 to investigate if this caused bug 633869

Probably didn't have to update the patch but since it is in my queue and needs approval again it was simpler.

Comment on attachment 517912 [details] [diff] [review] Updated 1.9.2 patch Approved for 1.9.2.16, a=dveditz for release-drivers

Pushed to mozilla-1.9.2 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0eb8c5c7441e