Closed
Bug 536058
Opened 15 years ago
Closed 15 years ago
Cannot use IME on subframes (e.g., iframe)
Categories
(Core :: DOM: Events, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | unaffected |
People
(Reporter: masayuki, Assigned: masayuki)
References
()
Details
(Keywords: inputmethod, regression)
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This is a regression of bug 532422.
*Only on trunk*, the patch breaks IME on subframes because the nsContentEventHandler doesn't get the correct selection. It gets the selection for the iframe's parent selection, not the textarea's selection.
If I click at outside of the textarea and I set focus to the textarea againg, I cannot reproduce this bug. So, I guess that there is focus management problem only on trunk.
This bug cannot be reproduced on the 1.9.2 branch's build, I'm not sure what is different between 1.9.2 branch and trunk.
Assignee | ||
Comment 1•15 years ago
|
||
The workaround cannot be used on gmail. So, this bug is blocker for the gmail users especially.
Assignee | ||
Updated•15 years ago
|
Priority: -- → P1
Comment 2•15 years ago
|
||
But still to clarify, this is trunk only, right?
I wonder what has changed on trunk. I don't recall anything selection handling related, nor focus handling related which is really that different on trunk.
Do we not dispatch the IME events to the right presshell on trunk?
Comment 3•15 years ago
|
||
Or actually, there is Bug 42676 and Bug 503943 which may have
changed things a bit on trunk.
Assignee | ||
Comment 4•15 years ago
|
||
(In reply to comment #2)
> But still to clarify, this is trunk only, right?
Yes, it's so, fortunately.
> Do we not dispatch the IME events to the right presshell on trunk?
IME events are dispatched in right content. However, the query content events and the selection set event isn't dispatched in right presshell.
(In reply to comment #3)
> Or actually, there is Bug 42676 and Bug 503943 which may have
> changed things a bit on trunk.
bug 42676 isn't cause the difference, probably.
I'm not sure bug 503943, however, perhaps, it isn't a cause of this because looks like it didn't change any logic for this bug.
Assignee | ||
Comment 5•15 years ago
|
||
bug 125282 could cause this...
Assignee | ||
Comment 6•15 years ago
|
||
(In reply to comment #5)
> bug 125282 could cause this...
I created the backed-out build, but this bug can be reproduce yet...
Assignee | ||
Comment 7•15 years ago
|
||
Sorry for the delay, I was sick unfortunately.
This bug is a simple mistake of the patch for trunk. I removed NS_IS_QUERY_CONTENT_EVENT and NS_IS_SELECTION_EVENT from NS_IsEventTargetedAtFocusedWindow, but I didn't change NS_IS_IME_EVENT to NS_IS_IME_RELATED_EVENT. Therefore, the presshell didn't retarget to the focused presshell.
Attachment #419225 -
Flags: review?(Olli.Pettay)
Updated•15 years ago
|
Attachment #419225 -
Flags: review?(Olli.Pettay) → review+
Assignee | ||
Comment 8•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Updated•15 years ago
|
Keywords: inputmethod
You need to log in
before you can comment on or make changes to this bug.
Description
•