Closed
Bug 536061
Opened 15 years ago
Closed 14 years ago
-moz-box-shadow doesn't well-support -moz-transform: translate() and/or rotate()
Categories
(Core :: Web Painting, defect, P2)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: ivan.enderlin, Assigned: MatsPalmgren_bugz)
References
()
Details
(4 keywords, Whiteboard: [3.6.x])
Attachments
(4 files)
(deleted),
text/html
|
Details | |
(deleted),
text/html
|
Details | |
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20091219 Minefield/3.7a1pre
Build Identifier:
When applying a -moz-box-shadow on a -moz-transform: translate(), the shadow isn't well-placed. It's shifted.
Look the source: <http://mozilla.hoa-project.net/Bug/Transform_and_shadow.html> or the PNG : <http://mozilla.hoa-project.net/Bug/Transform_and_shadow.png>.
Reproducible: Always
Reporter | ||
Updated•15 years ago
|
Comment 1•15 years ago
|
||
works: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.6) Gecko/20091201 Firefox/3.5.6
broken:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b6pre) Gecko/20091231 Namoroka/3.6b6pre
broken:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091231 Minefield/3.7a1pre
Updated•15 years ago
|
Flags: blocking1.9.2?
Updated•15 years ago
|
Component: DOM: CSS Object Model → Layout: View Rendering
QA Contact: general → layout.view-rendering
Comment 2•15 years ago
|
||
Regression range would be great.
Comment 3•15 years ago
|
||
build range
works:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20091006 Namoroka/3.6b1pre
broken:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20091007 Namoroka/3.6b1pre
Comment 4•15 years ago
|
||
Bug 513082 and maybe bug 514670 seem like possibilities after reading http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?startdate=2009-10-06+00%3A00%3A00&enddate=2009-10-07+08%3A00%3A00
Reporter | ||
Updated•15 years ago
|
Severity: normal → blocker
Reporter | ||
Comment 5•15 years ago
|
||
I've changed the bug's importance from normal to blocker (because of its regression nature).
Comment 6•15 years ago
|
||
My instinct is that this isn't a hard release blocker, and to clean it up in a 3.6.x release, but I don't know how common these sorts of things are. I would have expected to see more web-compatibility bugs if it was a common pattern, though.
David, Roc: thoughts on blocking?
Comment 7•15 years ago
|
||
It's unlikely to be a Web-compatibility problem since it's in the interaction of two features that aren't supported in IE. But it could affect things people are working on using those new features.
It would be good to know what the underlying problem is, but I think it's probably something that we could fix in a .1 release.
Updated•15 years ago
|
Flags: blocking1.9.2? → blocking1.9.2-
Whiteboard: [3.6.x]
Comment 9•15 years ago
|
||
inset shadows seem to be OK, so I'm guessing that maybe this is related to nsDisplayBoxShadowOuter::ComputeVisibility
Comment 10•15 years ago
|
||
So this used to work? That's odd, since bug 514670 only changed behaviour if the frame had border radii.
Comment 11•15 years ago
|
||
I think bug 513082 is the more likely cause.
Comment 12•15 years ago
|
||
Comment 13•15 years ago
|
||
The mozilla-central regression range, from Linux x86-64 nightlies, is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=db6d2486737d&tochange=3756cdca8b54
Comment 14•15 years ago
|
||
I confirmed via try server that http://hg.mozilla.org/mozilla-central/rev/b540248e3163 is broken and http://hg.mozilla.org/mozilla-central/rev/6bfb2b05290f works, which means this is in fact a regression from http://hg.mozilla.org/mozilla-central/rev/b540248e3163 .
Blocks: 513082
Assignee: nobody → roc
blocking2.0: --- → ?
Depends on: 564991
blocking2.0: ? → final+
Priority: -- → P2
Summary: Box-shadow doesn't well-support a translated transformation → -moz-box-shadow doesn't well-support -moz-transform: translate() and/or rotate()
Updated•14 years ago
|
Severity: blocker → normal
Comment 16•14 years ago
|
||
this attachment shows the -moz-box-shadow bug when using it with -moz-transform.
webkit and opera have a good behavior.
firefox nitghly x86 and x86_64 Linux builds are also affected.
Comment 17•14 years ago
|
||
See also testcase in duplicate bug 561119 - attachment 440798 [details]
Assignee | ||
Comment 21•14 years ago
|
||
Simple fix.
Assignee: roc → matspal
Attachment #490561 -
Flags: review?(roc)
Comment 22•14 years ago
|
||
There's only reftest for -moz-transform: translate(), shouldn't the test for -moz-transform: rotate() be included as well?
Comment on attachment 490561 [details] [diff] [review]
Patch rev. 1
Thanks!
Attachment #490561 -
Flags: review?(roc) → review+
(In reply to comment #22)
> There's only reftest for -moz-transform: translate(), shouldn't the test for
> -moz-transform: rotate() be included as well?
It doesn't really matter, the underlying code paths are the same.
Assignee | ||
Comment 25•14 years ago
|
||
Will push as soon as my Try run is green...
Assignee | ||
Comment 26•14 years ago
|
||
No longer blocks: 601512
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Comment 28•14 years ago
|
||
I tried backporting the patch to 1.9.2, but it didn't seem to work. Maybe I did something wrong, though.
And it looks like on 1.9.2 we need to fix the is-themed case in nsDisplayBackground as well. (I see transformed form controls failing in a similar way.)
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•