Closed
Bug 536721
Opened 15 years ago
Closed 14 years ago
"ASSERTION: Missing destruct root" with -moz-column
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: jruderman, Assigned: fantasai.bugs)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
bzbarsky
:
review+
dbaron
:
approval2.0+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: Missing destruct root: 'aDestructRoot', file /Users/jruderman/central/layout/generic/nsFrameList.cpp, line 95
Assertion was added in mozilla-central rev 1e37be566afa:
user: fantasai
date: Thu Dec 24 00:21:15 2009 -0500
summary: Bug 508473 part III: Pass destruction root to frame destruction methods r=bz sr=roc
|
||
Comment 1•15 years ago
|
||
nsContainerFrame::StealFrame calls DestroyOverflowList with a null (implicitly, since it doesn't pass the optional arg) destruct root.
We should just make that argument required. And if StealFrame really needs to pass null, then DestroyOverflowList needs to call the right framelist method.
Attachment #419653 -
Flags: review?(bzbarsky)
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 419653 [details] [diff] [review]
[checked-in] patch
Looks fine.
I guess null destruct root is particularly ok here because the list is in fact empty?
Attachment #419653 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 4•15 years ago
|
||
er, and DestructFrom and Destruct should be DestroyFrom and Destroy in the comment, right?
Need to land this fix so we can backport frame destruction cleanup to the branch(es)
Blocks: ZDI-CAN-852
|
||
Updated•14 years ago
|
No longer blocks: ZDI-CAN-852
|
|
||
Updated•14 years ago
|
Blocks: ZDI-CAN-852
Attachment #419653 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #419653 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•14 years ago
|
blocking2.0: --- → final+
|
||
Comment 6•14 years ago
|
||
Comment on attachment 419653 [details] [diff] [review]
[checked-in] patch
http://hg.mozilla.org/mozilla-central/rev/b98f0ecc5c7d
Attachment #419653 -
Attachment description: patch → [checked-in] patch
|
|
||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•