Closed
Bug 536945
Opened 15 years ago
Closed 15 years ago
Implement wrapping of tab previews in JS to avoid performance issues with display:block
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
People
(Reporter: dao, Assigned: dao)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: perf, Whiteboard: [tsnap])
Attachments
(1 file)
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
spin-off from bug 528531 comment 4:
> For the slow mouseover feedback performance I've found that removing
> display:block makes it a lot faster. Maybe we'll have to reimplement the
> wrapping in JavaScript - mixing display:block with XUL doesn't seem to work
> very well.
Attachment #419291 -
Flags: review?(mstange)
Comment 1•15 years ago
|
||
Comment on attachment 419291 [details] [diff] [review]
patch
Looks good and fixes the mouseover performance issues for me completely.
>+ row = this.container.childNodes.item(Math.floor(++i / this._columns));
Out of curiosity, why .item() and not []?
Attachment #419291 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 2•15 years ago
|
||
I thought [] would complain if the index was >= the length, but apparently it doesn't.
Comment 3•15 years ago
|
||
(In reply to comment #2)
> I thought [] would complain if the index was >= the length, but apparently it
> doesn't.
It should be a strict JavaScript warning. (e.g. document.createElement('label').childNodes[0])
Assignee | ||
Comment 4•15 years ago
|
||
I get the warning here:
> document.createElement('label').childNodes[0]
but not here:
> var foo = document.createElement('label').childNodes[0]
Assignee | ||
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Comment 6•15 years ago
|
||
Can you please file a layout bug, ideally with a testcase, on the slow-performance situation this worked around? It's not clear to me why display:block should be causing problems here.
Assignee | ||
Comment 7•15 years ago
|
||
(In reply to comment #6)
> Can you please file a layout bug, ideally with a testcase, on the
> slow-performance situation this worked around? It's not clear to me why
> display:block should be causing problems here.
filed bug 537037
Assignee | ||
Comment 8•15 years ago
|
||
Comment on attachment 419291 [details] [diff] [review]
patch
Requesting approval for an isolated change to visibly improve performance when interacting with the all-tabs panel. Only affects users who've toggled the hidden browser.allTabs.previews pref.
Attachment #419291 -
Flags: approval1.9.2.1?
Assignee | ||
Updated•15 years ago
|
Attachment #419291 -
Flags: approval1.9.2.1?
You need to log in
before you can comment on or make changes to this bug.
Description
•