Closed
Bug 536963
Opened 15 years ago
Closed 15 years ago
{inc}Bidi reordering bug with digits and linebreaks
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | .4-fixed |
People
(Reporter: smontagu, Assigned: smontagu)
References
Details
(Keywords: regression, verified1.9.2)
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
roc
:
review+
beltzner
:
approval1.9.2.2-
dveditz
:
approval1.9.2.4+
|
Details | Diff | Splinter Review |
The two paragraphs in the testcase have the same DOM and should be rendered identically.
Assignee | ||
Updated•15 years ago
|
Updated•15 years ago
|
Summary: Bidi reordering bug with digits and linebreaks → {inc}Bidi reordering bug with digits and linebreaks
Assignee | ||
Comment 1•15 years ago
|
||
I'm not completely sure why this makes a difference, since the new frame will get its offsets set on the next pass through the loop anyway, but apparently when that happens the next frame doesn't get its offsets reset.
Assignee | ||
Comment 2•15 years ago
|
||
I don't want to ask for blocking1.9.2 at this stage, especially since we already released 1.9.1 with this bug, but it's a regression that we should fix.
Flags: wanted1.9.2?
Keywords: regression
Attachment #419461 -
Flags: review?(roc) → review+
Flags: wanted1.9.2? → wanted1.9.2+
Assignee | ||
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Comment 4•15 years ago
|
||
Comment on attachment 419461 [details] [diff] [review]
Patch
Requesting approval1.9.2.1 after trunk baking.
Attachment #419461 -
Flags: approval1.9.2.1?
Comment 5•15 years ago
|
||
Comment on attachment 419461 [details] [diff] [review]
Patch
We'll likely take this for 1.9.2.3, even comes with tests.
Attachment #419461 -
Flags: approval1.9.2.3?
Attachment #419461 -
Flags: approval1.9.2.2?
Attachment #419461 -
Flags: approval1.9.2.2-
Comment 6•15 years ago
|
||
Comment on attachment 419461 [details] [diff] [review]
Patch
Approved for 1.9.2.4, a=dveditz for release-drivers
Attachment #419461 -
Flags: approval1.9.2.4? → approval1.9.2.4+
Assignee | ||
Comment 7•15 years ago
|
||
status1.9.2:
--- → .4-fixed
Comment 8•15 years ago
|
||
Verified for 1.9.2 using attached testcase with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4pre) Gecko/20100412 Namoroka/3.6.4pre (.NET CLR 3.5.30729). Text renders properly now.
Keywords: verified1.9.2
You need to log in
before you can comment on or make changes to this bug.
Description
•