Closed Bug 536963 Opened 15 years ago Closed 15 years ago

{inc}Bidi reordering bug with digits and linebreaks

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: smontagu, Assigned: smontagu)

References

Details

(Keywords: regression, verified1.9.2)

Attachments

(2 files)

Attached file Testcase (deleted) —
The two paragraphs in the testcase have the same DOM and should be rendered identically.
Blocks: 525788, 332655
Summary: Bidi reordering bug with digits and linebreaks → {inc}Bidi reordering bug with digits and linebreaks
Attached patch Patch (deleted) — Splinter Review
I'm not completely sure why this makes a difference, since the new frame will get its offsets set on the next pass through the loop anyway, but apparently when that happens the next frame doesn't get its offsets reset.
Assignee: nobody → smontagu
Status: NEW → ASSIGNED
Attachment #419461 - Flags: review?(roc)
I don't want to ask for blocking1.9.2 at this stage, especially since we already released 1.9.1 with this bug, but it's a regression that we should fix.
Flags: wanted1.9.2?
Keywords: regression
Flags: wanted1.9.2? → wanted1.9.2+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment on attachment 419461 [details] [diff] [review] Patch Requesting approval1.9.2.1 after trunk baking.
Attachment #419461 - Flags: approval1.9.2.1?
Comment on attachment 419461 [details] [diff] [review] Patch We'll likely take this for 1.9.2.3, even comes with tests.
Attachment #419461 - Flags: approval1.9.2.3?
Attachment #419461 - Flags: approval1.9.2.2?
Attachment #419461 - Flags: approval1.9.2.2-
Comment on attachment 419461 [details] [diff] [review] Patch Approved for 1.9.2.4, a=dveditz for release-drivers
Attachment #419461 - Flags: approval1.9.2.4? → approval1.9.2.4+
Verified for 1.9.2 using attached testcase with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4pre) Gecko/20100412 Namoroka/3.6.4pre (.NET CLR 3.5.30729). Text renders properly now.
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: