Closed
Bug 537846
Opened 15 years ago
Closed 15 years ago
Disable the "Reset" checkbox for the maintainer parameter
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: mkanat, Assigned: reed)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Since "maintainer" can no longer validly be reset, there shouldn't be an active reset checkbox for it.
Flags: blocking3.6+
Assignee | ||
Comment 1•15 years ago
|
||
Assignee: administration → reed
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•15 years ago
|
||
Comment on attachment 420215 [details] [diff] [review] wip This looks good so far, though you probably want to check $i->{'no_reset'}'s value, not just whether it exists.
Comment 3•15 years ago
|
||
(In reply to comment #2) > This looks good so far, though you probably want to check $i->{'no_reset'}'s > value, not just whether it exists. This just means removing "exists" in front of $i->{'no_reset'}. Anything else required before you request review, reed?
Assignee | ||
Comment 4•15 years ago
|
||
Attachment #420215 -
Attachment is obsolete: true
Attachment #425870 -
Flags: review?(mkanat)
Reporter | ||
Comment 5•15 years ago
|
||
Comment on attachment 425870 [details] [diff] [review] patch - v1 Looks good to me. Probably don't need quotes around the no_reset value in General.pm.
Attachment #425870 -
Flags: review?(mkanat) → review+
Reporter | ||
Updated•15 years ago
|
Flags: approval3.6+
Flags: approval+
Assignee | ||
Comment 6•15 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified editparams.cgi modified Bugzilla/Config/General.pm modified template/en/default/admin/params/common.html.tmpl Committed revision 6978. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/ modified editparams.cgi modified Bugzilla/Config/General.pm modified template/en/default/admin/params/common.html.tmpl Committed revision 6971.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•