Closed
Bug 537962
Opened 15 years ago
Closed 15 years ago
Update libffi to 3.0.9.
Categories
(Core :: js-ctypes, defect)
Core
js-ctypes
Tracking
()
RESOLVED
FIXED
People
(Reporter: jacek, Assigned: dwitte)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
After over a year, there was a new release of libffi 3.0.9. Looking at history there were only compilation fixes. I've applied a patch from bug 518969, let's see on try server if we still need the rest of fixes.
Reporter | ||
Comment 1•15 years ago
|
||
Patch gziped due to size limit on bugzilla.
Reporter | ||
Updated•15 years ago
|
Attachment #420112 -
Attachment is patch: false
Reporter | ||
Comment 2•15 years ago
|
||
Could someone with access to try server push it there, please?
Assignee | ||
Comment 3•15 years ago
|
||
I've got the 3.0.9 update in my patch queue, along with the two remaining local patches we need for it. (The remaining patches we had were upstreamed and released in 3.0.9.)
It passes on tryserver. I won't post the 3.0.9 patch here but I'll post the local patches.
Assignee | ||
Comment 4•15 years ago
|
||
This ports our current libffi patches to 3.0.9, and drops the ones that got upstreamed. I pulled the libffi tarball from the release website, ftp://sourceware.org/pub/libffi/libffi-3.0.9.tar.gz
bsmedberg, could you review/approve the 3.0.9 update and this patch? I should note that the project has switched to using git rather than cvs, so I can also update client.py if you'd like.
Assignee | ||
Comment 5•15 years ago
|
||
Actually, we can do away with the Solaris fix if we just pull it into Function.h, where we #include ffi.h. libffi itself is built with gcc, so it doesn't need the fix, but code built with Sun Pro does.
Attachment #420165 -
Attachment is obsolete: true
Attachment #420172 -
Flags: review?(benjamin)
Attachment #420165 -
Flags: review?(benjamin)
Updated•15 years ago
|
Attachment #420172 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1b205e684e06
http://hg.mozilla.org/mozilla-central/rev/2de1596d8413
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•