neil@parkwaycc.co.uk Assignee
	Description • 15 years ago

In the external string API, ToInteger takes an nsresult* parameter, which makes sense, since the result could be NS_ERROR_ILLEGAL_VALUE. However for historical sreason the internal API takes a PRInt32*. It should at least be possible to compile a module using an nsresult parameter using either string API.

	neil@parkwaycc.co.uk Assignee
	Comment 2 • 15 years ago

Pushed changeset 0124df25702b to mozilla-central.

	neil@parkwaycc.co.uk Assignee
	Comment 3 • 15 years ago

Comment on attachment 420628 [details] [diff] [review]
Proposed patch

It would be nice if this API could be added to the 1.9.2 branch as it would ease the porting of Thunderbird to libxul.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 4 • 15 years ago

Comment on attachment 420628 [details] [diff] [review]
Proposed patch

This missed 1.9.2.2, moving flag to 1.9.2.3

	Daniel Veditz [:dveditz]
	Comment 5 • 14 years ago

Comment on attachment 420628 [details] [diff] [review]
Proposed patch

Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.