Closed Bug 538555 Opened 15 years ago Closed 15 years ago

nsprpub/configure gets modified when i pymake

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: mak, Unassigned)

Details

I'm not sure if this is my fault, btw, when i rebuild with pymake the file is modified, a comment is removed, i suppose this happens when i call autoconf-2.13 in nsprpub, the docs in https://developer.mozilla.org/en/pymake tell me to do so though. this is the generated diff: diff --git a/nsprpub/configure b/nsprpub/configure --- a/nsprpub/configure +++ b/nsprpub/configure @@ -6152,17 +6152,17 @@ trap 'rm -f $CONFIG_STATUS conftest*; ex # Protect against Makefile macro expansion. cat > conftest.defs <<\EOF s%#define \([A-Za-z_][A-Za-z0-9_]*\) *\(.*\)%-D\1=\2%g s%[ `~#$^&*(){}\\|;'"<>?]%\\&%g s%\[%\\&%g s%\]%\\&%g s%\$%$$%g EOF -DEFS=`sed -f conftest.defs confdefs.h | tr '\012' ' ' | tr '\015' ' '` # Manually modified for MKS support. +DEFS=`sed -f conftest.defs confdefs.h | tr '\012' ' '` rm -f conftest.defs
We should fix the docs, then. NSPR has a pre-made configure built-in. wtc adds that trailing bit manually after running autoconf, which is why it disappears when you run autoconf there.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
I removed that line from the docs. It may have been leftover from a time where a NSPR patch was necessary to build.
oh, thanks!
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.