Closed Bug 538581 Opened 15 years ago Closed 15 years ago

Fix software update tests for fallback updates and version check

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

With the latest test runs against the betatest channel for testing the update to 3.6RC1 two issues have been shown which needs to be fixed. 1. The update.status file should contain a "failed: 6". ATM the whitespace is missing. 2. We need a better version check. While testing official releases we do not have a problem because no version prefix is used. But now with the update path from 3.6b5 to 3.6 a normal string comparison is not sufficient anymore. Dave, could you please point me to the code for the Addons Manager which is used for version comparison? I believe that I can use the identical way.
The version comparison is performed using nsIVersionComparator. One example in the em http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#5682 One example in app update http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#1255 I don't know if this affects you but nightly builds without a version bump will have the same version.
(In reply to comment #1) > The version comparison is performed using nsIVersionComparator. > > One example in app update > http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#1255 > > I don't know if this affects you but nightly builds without a version bump will > have the same version. That one is pretty helpful. Thanks Rob! In case of the updates which do not result in a version change I will take the buildID as an indicator that the update was successful.
Attached patch Patch v1 (deleted) — Splinter Review
This fixes the version comparison problems we had before and correctly mark the downloaded update as failed.
Attachment #420784 - Flags: review?(adesai)
Attachment #420784 - Flags: review?(adesai) → review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 527983
Whiteboard: [mozmill-test-failure]
Blocks: 562352
Whiteboard: [mozmill-test-failure] → [mozmill-automation][mozmill-test-failure]
Move of Mozmill related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Application Update → Mozmill Automation
Product: Toolkit → Mozilla QA
QA Contact: application.update → mozmill-automation
Whiteboard: [mozmill-automation][mozmill-test-failure]
Component: Mozmill Automation → Mozmill Tests
QA Contact: mozmill-automation → mozmill-tests
Summary: [mozmill] Fix software update tests for fallback updates and version check → Fix software update tests for fallback updates and version check
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: