Closed
Bug 538581
Opened 15 years ago
Closed 15 years ago
Fix software update tests for fallback updates and version check
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
aakashd
:
review+
|
Details | Diff | Splinter Review |
With the latest test runs against the betatest channel for testing the update to 3.6RC1 two issues have been shown which needs to be fixed.
1. The update.status file should contain a "failed: 6". ATM the whitespace is missing.
2. We need a better version check. While testing official releases we do not have a problem because no version prefix is used. But now with the update path from 3.6b5 to 3.6 a normal string comparison is not sufficient anymore.
Dave, could you please point me to the code for the Addons Manager which is used for version comparison? I believe that I can use the identical way.
Comment 1•15 years ago
|
||
The version comparison is performed using nsIVersionComparator.
One example in the em
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#5682
One example in app update
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#1255
I don't know if this affects you but nightly builds without a version bump will have the same version.
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1)
> The version comparison is performed using nsIVersionComparator.
>
> One example in app update
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#1255
>
> I don't know if this affects you but nightly builds without a version bump will
> have the same version.
That one is pretty helpful. Thanks Rob! In case of the updates which do not result in a version change I will take the buildID as an indicator that the update was successful.
Assignee | ||
Comment 3•15 years ago
|
||
This fixes the version comparison problems we had before and correctly mark the downloaded update as failed.
Attachment #420784 -
Flags: review?(adesai)
Updated•15 years ago
|
Attachment #420784 -
Flags: review?(adesai) → review+
Assignee | ||
Comment 4•15 years ago
|
||
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/6dab704be36c
http://hg.mozilla.org/qa/mozmill-tests/rev/8c255f721fcc
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Whiteboard: [mozmill-test-failure]
Assignee | ||
Updated•15 years ago
|
Whiteboard: [mozmill-test-failure] → [mozmill-automation][mozmill-test-failure]
Assignee | ||
Comment 5•14 years ago
|
||
Move of Mozmill related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Application Update → Mozmill Automation
Product: Toolkit → Mozilla QA
QA Contact: application.update → mozmill-automation
Whiteboard: [mozmill-automation][mozmill-test-failure]
Assignee | ||
Updated•14 years ago
|
Component: Mozmill Automation → Mozmill Tests
QA Contact: mozmill-automation → mozmill-tests
Summary: [mozmill] Fix software update tests for fallback updates and version check → Fix software update tests for fallback updates and version check
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•