Closed
Bug 538855
Opened 15 years ago
Closed 15 years ago
Mozmill: implement cleanup routine between test files to contain test failures to the same file
Categories
(Thunderbird :: Testing Infrastructure, defect)
Thunderbird
Testing Infrastructure
Tracking
(thunderbird3.0 .2-fixed)
RESOLVED
FIXED
Thunderbird 3.1a1
| Tracking | Status | |
|---|---|---|
| thunderbird3.0 | --- | .2-fixed |
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
asuth
:
review+
standard8
:
approval-thunderbird3.0.2+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•15 years ago
|
Version: 3.0 → Trunk
|
|
Assignee | |
Comment 1•15 years ago
|
||
I've tested this patch out a bit and it seems to work fine. This should hopefully catch everything but premature shutdowns. asuth, how does this work for you?
We're playing around a bit with mozmill internals, but I'm not too concerned about any of this changing in the near future.
|
|
Assignee | |
Comment 2•15 years ago
|
||
whoops.
Attachment #421010 -
Attachment is obsolete: true
Attachment #421011 -
Flags: review?(bugmail)
Attachment #421010 -
Flags: review?(bugmail)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 421011 [details] [diff] [review]
patch, v1.01
So, even my 1.9.1 tree is not super happy even without this, but I assert that helps this patch show its worth much better. Without the patch, some standalone message windows stack up. With the patch, they get gone. (And it does not break things that otherwise were reliable.) Hooray!
Attachment #421011 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 421011 [details] [diff] [review]
patch, v1.01
This would be good to land so that we get a better idea of which tests are failing.
Attachment #421011 -
Flags: approval-thunderbird3.0.2?
|
||
Updated•15 years ago
|
Attachment #421011 -
Flags: approval-thunderbird3.0.2? → approval-thunderbird3.0.2+
|
|
Assignee | |
Comment 6•15 years ago
|
||
status-thunderbird3.0:
--- → .2-fixed
|
|
||
Comment 7•15 years ago
|
||
Verifying as fixed for 3.0.2 based on the fact that these are test-only patches and the last 5 runs from MozMill/unit tests have been green with no failures relating to these patches.
Keywords: verified-thunderbird3.0
You need to log in
before you can comment on or make changes to this bug.
Description
•