I have two address books - my Personal Address Book, and Collected Addresses. The idea (in my mind, and presumably in the mind of the designers) is that the Personal Address Book is all the people I've explicitly said I know, and Collected Addresses is the set of people I've emailed, or who have emailed me, and whose addresses are therefore useful for autocompletion and the like. So I might sync the PAB with my phone, for example, but not Collected Addresses. If this is how it works then when I click a Star next to an address, I would expect it to add the address to the PAB. However, it adds it to Collected Addresses instead. :-( I think it should add it to the PAB. Gerv

This is basically the same issue as bug 456167 as different people will want different choices.

Mark: this bug is a subset of that one. That one seems to be asking for various bits of UI like an address book chooser, default prefs etc. This bug is saying that even if we don't have any of that, by default starring an address should put it in the PAB, not CA - on the basis that the PAB is addresses you explicitly care about, and CA is addresses Thunderbird thinks you may also care about. Starring something is an explicit action, and so the PAB should be the default. And this is something we should be able to change without creating any new UI. Gerv

Agreed.

is someone working on this? can we expect it on TB 3.0.2? thanks

Comment on attachment 429427 [details] [diff] [review] proposed fix Not using the address collector means that you don't get the first/last name fields filled in. You'd also loose the screen name collection, though that isn't too useful. I'd also question if we really want to hard-code this. At least with the old option the user could change where it was saved to at the expense of collecting to a different location (which I guess is then when we head towards bug 456167). However, I'll let Bryan make the call on what he wants us to do here.

Comment on attachment 429427 [details] [diff] [review] proposed fix I need to drag up previous bugs because I feel like we've gone through this a couple times now. The root problem being that there is no real definition to what the PAB and CAB are; some people use one as other people use the other. So neither default is going to be correct. I'd rather just wait on the address book chooser.

clarkbw: the key distinction is that some addresses are manually added, and some are automatically collected. The latter are useful for autocomplete, but I don't want to sync them with my PDA. Are there really people who use the Collected Addresses book for manually-added addresses and the PAB for automatically collected addresses? That would be just strange. Gerv

(In reply to comment #8) > Are there really people who use the Collected Addresses book for manually-added > addresses and the PAB for automatically collected addresses? That would be just > strange. I am a variation - automatic save to CAB is OFF and and I'm quite ahppy with CAB for new contacts. In other words I'm in tune with Bryan ... until an AB chooser becomes available or some combination of "the other bugs" [1], hard coding Personal AB is bad for me because most of my additions don't end up in PAB. But I am probably the exception. I offer as evidence http://gsfn.us/t/nsu9 StarMoveContact add-on allows setting AB in the save UI and works peachy for me https://addons.mozilla.org/fr/thunderbird/addon/72070 [1] Bug 420867 preference to set default address book name for Address Book UI and other bugs I am hard pressed to identify ATM.

Comment on attachment 429427 [details] [diff] [review] proposed fix As I've already commented, some parts of this patch loose what we have in the existing code, and I'm not sure about the rest. In any case, clearing review request until you get agreement with Bryan as to the way forward from the UX perspective.

ah, bug 471580 is what I was looking for

Comment on attachment 429427 [details] [diff] [review] proposed fix This change actually seems fine to me other than the problem that at this point we're jerking people around for where contacts are being stored. I can't find older bugs on this issue but I really felt like we've already had this discussion. If we merge this with the change in bug 456167 then I can ui-r+ this. and bug 456167 appears to have stalled so perhaps someone could offer to take it over.

:clarkbw: I agree we are moving around where contacts are stored, but having specifically-chosen contacts go into the same address book as automatically-gathered contacts is just a complete disaster, and the sooner we fix it the better. Also, it's an utter misnomer - "my personally chosen addresses go into 'Collected Addresses' not my 'Personal Address Book' - huh?" Putting it all in one place was the big mistake. This is just fixing it. Gerv

Agree with Gerv, as long as the change here doesn't break the extension https://addons.mozilla.org/cs/thunderbird/addon/72070 or preclude bug 456167 happening (sorta kidding, sorta serious). IOW if the the default behavior is going to change, people should have an override option. Bryan, I think bug 456167 is the definitive bug at this point - but can it realistically be delivered in v3.1?

(In reply to comment #13) > :clarkbw: I agree we are moving around where contacts are stored, but having > specifically-chosen contacts go into the same address book as > automatically-gathered contacts is just a complete disaster, and the sooner we > fix it the better. Also, it's an utter misnomer - "my personally chosen > addresses go into 'Collected Addresses' not my 'Personal Address Book' - huh?" Everyone has different semantics for the address books. Even in this bug but I've discussed with plenty of other people who use the Collected Addresses as their only address book because it has all the addresses they use. Switching for them would be a regression at this point. I think waiting until we have the chooser is the right path as we've already selected one location and the chooser allows you to move the addresses between them.

(In reply to comment #15) > Switching > for them would be a regression at this point. Surely only if they are exporting or syncing their address books? Address completion works across all books. Gerv

bug 456167 took care of this one ->FIXED