Closed Bug 539133 Opened 15 years ago Closed 13 years ago

remove broken Opera profile migrator

Categories

(Firefox :: Migration, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 11

People

(Reporter: dietrich, Assigned: m_kato)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file, 1 obsolete file)

From File/Import, the only option available is "cookies". When importing on "first run", the wizard shows the homepage import option, but only shows a single choice: the Firefox default homepage. Then the next page says migration complete, and the summary shows only cookies as being imported.
Whiteboard: [3.6RC1]
By code inspection, the Opera profile migrator hard-codes Opera 6-specific file names. Chances are that Opera has renamed the files since then.
OS: Linux → All
Hardware: x86 → All
Whiteboard: [3.6RC1]
Attached patch fix (obsolete) (deleted) — Splinter Review
Attachment #578176 - Flags: review?(gavin.sharp)
Does this fix all of the issues on all platforms? I'm pretty tempted to just remove the Opera profile migrator, at least until we can rewrite it in JS and properly test it fully.
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3) > Does this fix all of the issues on all platforms? I'm pretty tempted to just > remove the Opera profile migrator, at least until we can rewrite it in JS > and properly test it fully. Yes. Opera 11 uses same filename on all platform (Windows/MacOSX/Linux). Current code seems to be for Opera 6 per comment #1. Also, I agree that we remove opera migration until rewriting new JS based code. (although we need ini parser for js components...) Gavin, should I remove this migration?
Yeah, let's just kill it, and file a followup to re-implement if needed.
Blocks: 707601
Attached patch fix (deleted) — Splinter Review
kill opera migrator.
Assignee: nobody → m_kato
Attachment #578176 - Attachment is obsolete: true
Attachment #578981 - Flags: review?(gavin.sharp)
Attachment #578176 - Flags: review?(gavin.sharp)
(In reply to Makoto Kato from comment #4) > (although we need ini parser for js components...) What's wrong with nsIINIParser?
Comment on attachment 578981 [details] [diff] [review] fix A couple of things you forgot to remove: - NS_OPERAPROFILEMIGRATOR_CID #define in nsBrowserCompsCID.h, and a reference to it in nsModule.cpp - importFromOpera strings in migration.dtd r=me with those addressed, thanks!
Attachment #578981 - Flags: review?(gavin.sharp) → review+
Status: NEW → ASSIGNED
Whiteboard: [inbound]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Summary: Various parts of migration from Opera are broken → remove broken Opera profile migrator
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: