Closed
Bug 539357
Opened 15 years ago
Closed 2 years ago
Move URL-bar specific code out of autocomplete.xml and into urlbarBindings.xml
Categories
(Toolkit :: XUL Widgets, defect)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
INACTIVE
People
(Reporter: Unfocused, Unassigned)
Details
Currently, the bindings in autocomplete.xml have code that is specific to the browser URL-bar. This is making debugging, maintaining, and changing things very difficult. URL-bar specific code should be moved to the relevant bindings in urlbarBindings.xml, which inherit from the bindings in autocomplete.xml
Comment 1•15 years ago
|
||
I'm assuming you're referring to most of the "autocomplete-richlistitem" binding? We should consider the compat cost of moving some of this code out of the toolkit, but I think we probably have a lot of leeway given that it's pretty UI-specific, as you mention. Fennec, for example, already redefines it's own custom autocomplete popup rather than using the default one.
Reporter | ||
Comment 2•15 years ago
|
||
Yes, mostly the "autocomplete-richlistitem" binding. I think the gains outweigh the compat cost - especially given you usually have to completely override and re-implement certain methods just to change something. Hopefully separating out the urlbar-specific stuff will make that easier for the generic case (changing the normal autocomplete).
Comment 3•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:mstriemer, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee: blair → nobody
Flags: needinfo?(mstriemer)
Updated•2 years ago
|
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mstriemer)
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•