Closed
Bug 539684
Opened 15 years ago
Closed 15 years ago
[HTML5][Patch] Serializer tests fail due to whitespace differences and doctype case differences
Categories
(Core :: DOM: HTML Parser, defect, P1)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
laurent
:
review+
|
Details | Diff | Splinter Review |
/tests/content/base/test/test_bug424359-1.html and
/tests/content/base/test/test_bug424359-2.html
fail due to differences in whitespace and the case of the string "html" in the doctype.
|
Assignee | |
Comment 1•15 years ago
|
||
Also content/base/test/test_bug498433.html
|
|
Assignee | |
Comment 2•15 years ago
|
||
This patch does the following:
* Removes whitespace before the first child of <head> to avoid hitting whitespace treatment differences between the old parser and the HTML5 parser.
* Removes whitespace near the end of the document for the same reason.
* Removes ⟨ and ⟩ testing, because those got reassigned. (I'll file a separate bug about dealing with the change in the serializer.)
* Before comparing the actual and expected values, "<!DOCTYPE HTML" in actual is folded to "<!DOCTYPE html" to make the old parser pass.
|
|
Assignee | |
Updated•15 years ago
|
Summary: [HTML5] Serializer tests fail due to whitespace differences and doctype case differences → [HTML5][Patch] Serializer tests fail due to whitespace differences and doctype case differences
|
|
Assignee | |
Comment 3•15 years ago
|
||
This patch assumes the patch for bug 520581 is applied first.
Depends on: 520581
|
||
Comment 4•15 years ago
|
||
Comment on attachment 422507 [details] [diff] [review]
Make serializer tests not depend on old vs. new parser differences
ok for me
Attachment #422507 -
Flags: review?(laurent) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•