Open
Bug 540222
Opened 15 years ago
Updated 2 years ago
--disable-xul means NS_STYLE_DISPLAY_INLINE_GRID is undefined, compile failure
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
NEW
People
(Reporter: WeirdAl, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•15 years ago
|
Attachment #422041 -
Attachment is patch: true
Attachment #422041 -
Attachment mime type: application/octet-stream → text/plain
Reporter | ||
Updated•15 years ago
|
Attachment #422041 -
Flags: superreview?(bzbarsky)
Attachment #422041 -
Flags: review?(bzbarsky)
Comment 1•15 years ago
|
||
It looks like this makes the checks for NS_STYLE_DISPLAY_INLINE_{GRID,STACK} ifdef-ed out, but not the one for ...INLINE_BOX, which the bug's summary suggests is the problem.
Reporter | ||
Comment 2•15 years ago
|
||
Whoops - I'm pretty sure the patch is right and the summary is wrong. :(
Summary: --disable-xul means NS_STYLE_DISPLAY_INLINE_BOX is undefined, compile failure → --disable-xul means NS_STYLE_DISPLAY_INLINE_GRID is undefined, compile failure
Updated•15 years ago
|
Attachment #422041 -
Flags: superreview?(bzbarsky)
Attachment #422041 -
Flags: review?(bzbarsky)
Attachment #422041 -
Flags: review+
Comment 3•15 years ago
|
||
Comment on attachment 422041 [details] [diff] [review]
patch, v1
r=bzbarsky (no sr needed here).
Comment 4•11 years ago
|
||
Can this still be checked in?
Comment 5•8 years ago
|
||
I don't think we support --disable-xul anymore, but "#ifdef MOZ_XUL" might be good
anyway for documentation. I would rather see that we try to *remove* XUL though,
than maintaining it.
Component: Layout → XUL
Updated•2 years ago
|
Severity: minor → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•