Closed Bug 540322 Opened 15 years ago Closed 13 years ago

Improve the external string API to align it with the internal string API

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file, 1 obsolete file)

Fixed patch
(deleted), patch
benjamin
: review+
Details | Diff | Splinter Review 
The external string API lacks many methods provided on the internal string API. This makes it hard to write code that compiles against both APIs. In particular it would be useful if the following methods were stubbed:
Last
SetCharAt
AssignASCII [the internal API AssignLiteral only works on a real literal]
AppendASCII [ditto]
LowerCaseEqualsLiteral (missing from nsACString only)
Attached patch Proposed patch (obsolete) (deleted) — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #422119 -
        Flags: review?(benjamin)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fixed patch (deleted)
        — 
          — Splinter Review
      

    


  
Bah, I forgot that internal SetCharAt has the char first.

        Attachment #422119 -
        Attachment is obsolete: true

        Attachment #422189 -
        Flags: review?(benjamin)

        Attachment #422119 -
        Flags: review?(benjamin)

    
  

        Attachment #422189 -
        Flags: review?(benjamin) → review+

    
  
Depends on: post2.0

    
    

    
  
Pushed changeset e3ce9abae2d5 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
    

    
  
It's possible that this changed caused bug 682259. Can someone please have a look and confirm?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: