Closed
Bug 540892
Opened 15 years ago
Closed 15 years ago
Stop using nsIDOMNode tree traversals
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: surkov)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
patch
|
davidb
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
One of the things that really slows down ApplyEventRules (apart from it being called too much and doing too much) is that it works on nsIDOMNodes. In particular, nsCoreUtils::AreSiblings and nsCoreUtils::IsAncestorOf are fairly expensive operations involving a bunch of QI calls, refcounting, etc, etc.
This code should probably use nsINode instead.
Comment 1•15 years ago
|
||
Thanks! Assigning to Alexander after some IRC discussion. This seems well scoped and we'll do it for events as a first step.
Assignee: nobody → surkov.alexander
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #422983 -
Flags: superreview?(bzbarsky)
Attachment #422983 -
Flags: review?(bolterbugz)
Reporter | ||
Comment 3•15 years ago
|
||
Comment on attachment 422983 [details] [diff] [review]
patch
sr=bzbarsky
Attachment #422983 -
Flags: superreview?(bzbarsky) → superreview+
Comment 4•15 years ago
|
||
Comment on attachment 422983 [details] [diff] [review]
patch
r=me.
>@@ -1163,17 +1166,16 @@ nsRootAccessible::HandlePopupHidingEvent
> if (comboboxRole == nsIAccessibleRole::ROLE_COMBOBOX ||
> comboboxRole == nsIAccessibleRole::ROLE_AUTOCOMPLETE) {
> nsRefPtr<nsAccEvent> event =
> new nsAccStateChangeEvent(comboboxAcc,
> nsIAccessibleStates::STATE_EXPANDED,
> PR_FALSE, PR_FALSE);
> NS_ENSURE_TRUE(event, NS_ERROR_OUT_OF_MEMORY);
>
>- nsRefPtr<nsAccessible> acc(nsAccUtils::QueryAccessible(comboboxAcc));
Aside: what was that line all about?
Attachment #422983 -
Flags: review?(bolterbugz) → review+
Assignee | ||
Comment 5•15 years ago
|
||
(In reply to comment #4)
> Aside: what was that line all about?
It's rudiment from bug 5402727.
Assignee | ||
Comment 6•15 years ago
|
||
(In reply to comment #5)
> (In reply to comment #4)
>
> > Aside: what was that line all about?
>
> It's rudiment from bug 5402727.
bug 540272
Assignee | ||
Comment 7•15 years ago
|
||
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/202a07f8110b
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•