User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729) When using the following piece of HTML code, I expected FF 3.6 to display a button without text inside. <button style="height: 20px; overflow: hidden; text-indent: 300px; width: 200px;">text</button> Reproducible: Always Steps to Reproduce: 1. Create a new HTML file with your favorite editor. 2. Add this button to your HTML body : <button style="height: 20px; overflow: hidden; text-indent: 300px; width: 200px;">text</button> 3. Open your HTML file with FF 3.6 Actual Results: Text appears next to the button, as if "overflow: hidden" had no effect. Expected Results: Text should be hidden.

This works fine with FF 3.5 and below.

From the regression range below this is from Bug 491180 which means this was an intended change: 0722 text not shown http://hg.mozilla.org/mozilla-central/rev/02f8bf10f441 0723 text shown http://hg.mozilla.org/mozilla-central/rev/d783d91beec5 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=02f8bf10f441&tochange=d783d91beec5

well, Fx 3.5, Chrome 4 dev and Opera 10.5 behave equally on above testcase. really intended?

Man. Safari's changed its behavior since the patch for bug 491180 (and in particular they now clip the text in the data: testcase from bug 491180 comment 9. The non-visible-overflow behavior is of course bogus, but I wonder whether we should try clipping the non-positioned text in the visible case. My gut feeling is "no" (especially since it would be a pain). roc?

Or maybe I got Webkit and Opera backwards in bug 491180? Opera's not clipping that text from the data: URI....

Pushed http://hg.mozilla.org/mozilla-central/rev/b5a9cb0708ac

Comment on attachment 423117 [details] [diff] [review] The minimal fix We should get this in on branch.

Does it have tests? It feels like this should have tests!

> Does it have tests? There's a reftest in the patch, yes....

Comment on attachment 423117 [details] [diff] [review] The minimal fix We missed 1.9.2.2. Moving approval request forward.

(In reply to comment #13) > (From update of attachment 423117 [details] [diff] [review]) > We missed 1.9.2.2. Moving approval request forward. It seems that we missed 1.9.2.3 too...

1.9.2.3 was a security firedrill release. It was 1.9.2 plus exactly one fix. The release that was planned to be 1.9.2.3 just got renamed to 1.9.2.4.

Comment on attachment 423117 [details] [diff] [review] The minimal fix Approved for 1.9.2.6, a=dveditz for release-drivers

Pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/f2adbb501cd9

VERIFIED FIXED on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.7) Gecko/20100701 Firefox/3.6.7, screenshot attached.