Closed Bug 541709 Opened 15 years ago Closed 7 years ago

Names of bookmarks in Bookmarks Toolbar Menu (under Bookmarks Menu) are not live updated

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: bugchilla, Unassigned)

References

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 This "problem" occured after upgrading Firefox to v3.6 (from newest 3.5.x). Now when i change a bookmark entry (name of the bookmark) in the bookmarks manager (e.g. "http://www.t-online.de" to "T-Online") the bookmarks manager shows the new name as before (in this case "T-Online"), BUT the bookmarks menu still displays the old name (in this case: "http://www.t-online.de"). The name gets not updated until i restart Firefox. Reproducible: Always Steps to Reproduce: 1. Add a bookmark 2. Change it's name in the bookmark manager Actual Results: Firefox's bookmark menu (not the bookmark manager, which refreshes the name like it should) still displays the old name until restart. Expected Results: In Firefox v 3.0.x / 3.5.x the bookmarks menu updated the name promptly
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.1pre) Gecko/20100122 Namoroka/3.6.1pre This works fine for me, on Windows at least.
Even when adding a new bookmark and changing it's name before clicking the "Fertig" (english should be "Finish") checkbox to finally add the bookmark, The bookmarks menu regardlessly displays the standard name For EXAMPLE: Adding this page: 1. I click "Command" + "D" for adding a bookmark 2. "Edit this bookmark" window pops up, the standard name for this page is "Bug 541709 – Bookmarks menu: Names of bookmarks do not get updated when changed in the bookmarks manager" 3. I edit the name to "Bug 541709" and click "Fertig" (finish). 4. The bookmarks manager shows this bookmark as "Bug 541709". 5. BUT the bookmarks menu still shows "Bug 541709 – Bookmarks menu: Names of bookmarks do not get updated when changed in the bookmarks manager" until restart of Firefox. Greets, bugchilla
I noticed that closing Firefox's main window without shutting down the app (this is not possible on Windows, in any case not out of the box) and opening a new window also refreshes the bookmarks menu. Now this page's bookmark is shown as "Bug 541709" (referred to the example above).
Additionally to my last comment: I do not have to close the main window before opening a new one in which i get an updated view of the bookmarks menu. Opening a new window is enough to get a refreshed view. When i change between the first window (old one, opened before and while adding the bookmark) and the second one (opened after adding the bookmark) the old window still does not refresh the bookmarks menu (meaning it still displays the bookmark name as it was before beeing edited) but the secondly opened window displays the new, edited name of the bookmark. To me this seems like a menubar issue. The Menubar does not get updated unless one opens a new window. In the latter case it only updates for the new window, the old window's menubar does not update, too. Greets and thanks in advance for fixing! bugchilla
Looks like a problem with our native menu, --> Widget: Cocoa
Component: Bookmarks & History → Widget: Cocoa
Product: Firefox → Core
QA Contact: bookmarks → cocoa
I can confirm this in the latest nightly. I dragged the "Minefield Start Page" to the BM toolbar, then opened the Bookmarks manager and edited the name to "Minefield edited". In the Bookmarks menu, the name is still "Minefield Start Page". As the reporter, if I open a new window the Bookmarks menu belonging to that window shows the right name.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
this is an XBL bug, that we have workarounded in bug 529062
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
Marco, I don't see how this can be a dupe of bug 529062 since I see this in a recent nightly and the fix for bug 529062 landed for over a month ago.
(In reply to comment #9) > Marco, I don't see how this can be a dupe of bug 529062 since I see this in a > recent nightly and the fix for bug 529062 landed for over a month ago. Sorry comment 0 was about 3.6, and i got confused, reopening.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(In reply to comment #6) > I can confirm this in the latest nightly. I dragged the "Minefield Start Page" > to the BM toolbar, then opened the Bookmarks manager and edited the name to > "Minefield edited". In the Bookmarks menu, the name is still "Minefield Start > Page". As the reporter, if I open a new window the Bookmarks menu belonging to > that window shows the right name. Though, i have a doubt, why did you say to drag the page to the toolbar, and then you say the name does not change on the menu? which name did you edit? is that a typo?
oh THAT menu. i missed the screenshot.
it is probably still due to bug 529062, we don't force the binding on that menu, because it's not generated on the fly by our code. So it's a remaining part.
Depends on: 529062
Status: REOPENED → NEW
Summary: Bookmarks menu: Names of bookmarks do not get updated when changed in the bookmarks manager → Names of bookmarks in Bookmarks Toolbar Menu (under Bookmarks Menu) are not live updated
This WFM on latest 60.0 nightly on Mac, and I've not seen any issues relating to it whilst I've been working on bookmarks over the last few months, so I think this is WFM now.
Status: NEW → RESOLVED
Closed: 15 years ago7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: