Mostly test changes - I've removed the print preview tests because getting them working is non-trivial and I plan to rip out in-window previewing anyway.

The last time browser_bug386835.js caught a print preview regression was in bug 544018 comment 23 :/

Comment on attachment 428858 [details] [diff] [review] Patch Sorry about the delay reviewing this! >+ // Avoid the cps roundtrip and apply the default/global setting. Nit: setting -> pref! >+ var self = this; >+ this._cps.getPref(aURI, this.name, function(aResult) { >+ // Check that we're still where we expect to be in case this took a while. >+ let isSaneURI = (aBrowser && aBrowser.currentURI) ? >+ aURI.equals(aBrowser.currentURI) : false; >+ if (!aBrowser || isSaneURI) >+ self._applyPrefToSetting(aResult, aBrowser); >+ else >+ self._applyPrefToSetting(); >+ }); If the browser's current URI is different than the one for which we got the pref, is it possible that the application of the default/global pref will race the application of the site-specific pref for the new URL? And is it necessary to apply the default/global pref at all if the URLs differ? Presumably onLocationChange will get called again for the new URL, and it'll apply either the site-specific pref for that URL or the default/global pref.

(In reply to comment #3) > If the browser's current URI is different than the one for which we got the > pref, is it possible that the application of the default/global pref will race > the application of the site-specific pref for the new URL? > > And is it necessary to apply the default/global pref at all if the URLs differ? It can indeed race, and no, it's not necessary. I think I added that while debugging something and simply forgot to remove it.

Comment on attachment 433472 [details] [diff] [review] Patch v2 >diff --git a/browser/base/content/browser-fullZoom.js b/browser/base/content/browser-fullZoom.js >- var browser = aBrowser || gBrowser.selectedBrowser; >+ var browser = aBrowser || (gBrowser && gBrowser.selectedBrowser); Heh, funky, but I guess it works. r=myk!

Zoomed page does not flicker after switching back tab.

Oops,Sorry, I have transmitted a message by mistake.

Is variable name isSaneURI in the patch a spelling mistake of isSameURI?