Closed Bug 54216 Opened 24 years ago Closed 22 years ago

merge helperAppDldProgress.xul/.js back into the original downloadProgress.xul/.js

Categories

(Core Graveyard :: File Handling, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mscott, Assigned: mscott)

References

Details

This is just a reminder to go clean some stuff up after we ship. I cloned Bill's downloadProgress xul and JS and then modified it to work using the nsIWebProgressListener interface for reporting progress from the helper app dialog. I cloned the file because we were in a hurry to get it together as fast as possible. But this makes maintence hard because we have two places were the progress code needs to be maintained. There's no reason why we can't change downloadProgress to implement nsIWebProgress and use the observer notifications Bill currently has it using. That way, it can be invoked from the helper app stuff and from the unknown content dialog. Based on the object passed into the dialog (if it's a nsIHelperAppLauncher, we'll register our progress listener, etc) we can determine the right behavior.
mass move, v2. qa to me.
QA Contact: tever → benc
Component: Networking → File Handling
Is this just bug 67216?
Depends on: 67216
QA Contact: benc → sairuh
QA Contact: sairuh → petersen
These files no longer exist: chb@frodo:~/mozilla/embedding/components/ui/progressDlg$ find ~/mozilla -name helperAppDldProgress.xul chb@frodo:~/mozilla/embedding/components/ui/progressDlg$ find ~/mozilla -name helperAppDldProgress.js chb@frodo:~/mozilla/embedding/components/ui/progressDlg$ marking worksforme.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.