Closed
Bug 542738
Opened 15 years ago
Closed 15 years ago
nsLocalFile::IsWritable/IsReadable/IsExecutable is wrong on Solaris
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
It is also wrong on BeOS.
But I'll only fix it for Solaris here.
The behavior is changed in Bug 351950, it explains why using access() is not good on Solaris.
The comment said Bug 351595, it is a typo.
|
||
Comment 1•15 years ago
|
||
(In reply to comment #0)
> It is also wrong on BeOS.
> But I'll only fix it for Solaris here.
>
> The behavior is changed in Bug 351950, it explains why using access() is not
> good on Solaris.
> The comment said Bug 351595, it is a typo.
Thanks. Now I understand what the issue was, I think. I guess we need to
fix the typo in the said also!
TIA
The BeOS implementation is not correct, it is better than nothing, since access() is always 0 on BeOS according to Bug 169506.
On Solaris, the only problem we want to resolve if IsExecutable() with root user.
Using BeOS implementation is actually a step backwards.
|
||
Comment 3•15 years ago
|
||
Comment on attachment 423978 [details] [diff] [review]
patch
This makes solaris work more like linux with the exception of IsExecutable(). That sounds fine to me. Please make sure that you run the tests and nothing is an issue.
Attachment #423978 -
Flags: review?(mozbugz) → review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•