Closed
Bug 543438
Opened 15 years ago
Closed 15 years ago
TestBlockingProcess relies on stdin to "block"
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a4
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
The sole purpose of the TestBlockingProcess program is to live long enough to be able to kill it from the nsIProcess unit test. It currently relies on stdin to block, which is both a wrong assumption and an accurate way to have the nsIProcess unit test fail some particular environments (probably with the help of another bug in either nsProcess or NSPR, depending how one regards the issue, that I'll file right after this one).
Such particular environments include those where stdin is not a tty (and it so happens in some Debian build environments, such as pbuilder).
The result is that depending on the environment, TestBlockingProcess may or may not be "blocking". As its sole purpose is to be alive long enough to be killed by the nsIProcess unit test, it'd be just fine to loop on a sleep() call.
Assignee | ||
Comment 1•15 years ago
|
||
Assignee: nobody → mh+mozilla
Attachment #424567 -
Flags: review?(benjamin)
Updated•15 years ago
|
Attachment #424567 -
Flags: review?(benjamin) → review?(dtownsend)
Updated•15 years ago
|
Attachment #424567 -
Flags: review?(dtownsend) → review+
Updated•15 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a3
Comment 3•15 years ago
|
||
Backed out.
e:/builds/moz2_slave/mozilla-central-win32/build/xpcom/tests/TestBlockingProcess.cpp(1) : fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267790762.1267791982.4339.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla1.9.3a3 → ---
Assignee | ||
Comment 4•15 years ago
|
||
(In reply to comment #3)
> Backed out.
>
> e:/builds/moz2_slave/mozilla-central-win32/build/xpcom/tests/TestBlockingProcess.cpp(1)
> : fatal error C1083: Cannot open include file: 'unistd.h': No such file or
> directory
>
> http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267790762.1267791982.4339.gz
Really, I'm puzzled. unistd.h is a standard header, and it's used all over the place in the source... O_o
Assignee | ||
Comment 5•15 years ago
|
||
So, apparently, this should be protected in a #if !defined(XP_WIN) && !defined(XP_OS2)
I don't know where sleep() is supposed to be defined on these.
Assignee | ||
Comment 6•15 years ago
|
||
It'd be better to use PR_Sleep, I guess. Let me try that.
Assignee | ||
Comment 7•15 years ago
|
||
This one should work everywhere
Attachment #424567 -
Attachment is obsolete: true
Attachment #430601 -
Flags: review?(dtownsend)
Updated•15 years ago
|
Attachment #430601 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 8•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
You need to log in
before you can comment on or make changes to this bug.
Description
•