Closed Bug 543528 Opened 15 years ago Closed 3 years ago

[SeaMonkey 2.1] mochitest-plain: multiple "test_bug260264.html | not properly opened"

Categories

(Core :: DOM: Events, defect)

Product:
Core
Component:
DOM: Events
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: sgautherie, Unassigned)

References

(
URL
)

Details

(Whiteboard: [fixed by bug 523885])

Attachments

(1 file)

Patch to make window.open() use tabs instead of browser windows.
(deleted), patch
jst
: review+
Details | Diff | Splinter Review
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1265045459.1265050902.22832.gz Linux comm-central-trunk debug test mochitests on 2010/02/01 09:30:59 { 51038 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/bugs/test_bug260264.html | not properly opened [...] 51084 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/bugs/test_bug260264.html | Windows left open by previous tests? }
I can reproduce this running the test individually, so I'll look into it.
Assignee: nobody → bnewman
Status: NEW → ASSIGNED
The failure is due to SeaMonkey window.open()ing new browser windows instead of tabs. The easiest fix is to set browser.link.open_newwindow to 3 (open in tabs). One nice advantage of this change is that it speeds up the test substantially (tabs are a lot quicker to open/close than browser windows). Apparently we set the docshell to null too late when closing a browser window, so gOpenPopupSpamCount is not reclaimed before we try to open another popup. If this tests starts failing again, it will probably need to be rewritten to cope with the asynchronicity of window.close(). That would be a pretty invasive rewrite, I think. Since this problem only affects the testability of bug 260264, not the UI behavior, I would recommend simply disabling this test if there are further problems. This should land on mozilla-central as well, just to be safe, even though window.open() currently opens tabs by default on m-c.
Attachment #424701 - Flags: superreview?(jst)
Attachment #424701 - Flags: superreview?(jst) → review?(jst)
Attachment #424701 - Flags: review?(jst) → review+
This bug will be fixed by my patch for bug 523885, but the patch I posted above is still worthwhile for the sake of test speed.
Depends on: 523885
Expected to be fixed by bug 523885: need bug 504344 to confirm...
Depends on: 504344
Summary: [SeaMonkey trunk] mochitest-plain: multiple "test_bug260264.html | not properly opened" → [SeaMonkey 2.1] mochitest-plain: multiple "test_bug260264.html | not properly opened"
Bug 523885 was backed out, so not fixed yet. *** http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1267346251.1267359169.7390.gz OS X 10.5 comm-central-trunk debug test mochitests on 2010/02/28 00:37:31 MacOSX too.
(In reply to comment #3) > This bug will be fixed by my patch for bug 523885, but the patch I posted above V.Fixed per SM21 tinderboxes. > is still worthwhile for the sake of test speed. Shall you land it now?
No longer blocks: CcMcBuildIssues
Severity: normal → major
OS: Linux → All
Hardware: x86 → All
Whiteboard: [fixed by bug 523885]
What's up with the patch in here? The test failure seems to be fixed for good.
No longer blocks: SmTestFail
QA Whiteboard: qa-not-actionable

The bug assignee didn't login in Bugzilla in the last 7 months.
:hsinyi, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: mozilla+ben → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(htsai)

the test runs on desktop firefox. I think that is in practice good enough.
If not, please reopen.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(htsai)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: