Closed Bug 543857 Opened 15 years ago Closed 15 years ago

In Weave's change-password/passphrase dialogs, the success message pushes OK/Cancel buttons off the bottom

Categories

(Firefox :: Sync, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED

People

(Reporter: dholbert, Assigned: mconnor)

References

Details

(Keywords: polish)

Attachments

(7 files)

STEPS TO REPRODUCE: 1. In Weave Preferences, click "Manage Account" 2. Click "Change Password" or "Change Secret Phrase" 3. Complete the dialog, and press 'Enter' or click 'OK' ACTUAL RESULTS: - "Your password was successfully changed"! message appears above Cancel/OK buttons, pushing them partially outside of the dialog. - The dialog disappears a second later. But while it's still visible, it looks broken. (See upcoming screenshot.) EXPECTED RESULTS: Buttons should not move. (Perhaps some space should be pre-allocated on the dialog for the success message?) I'm using: Weave Sync 1.0 Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100202 Minefield/3.7a1pre Ubuntu 9.10 (Karmic)
Summary: Weave's password/passphrase change dialogs are too small for success message + Ok/Cancel buttons → In Weave's change-password/passphrase dialogs, the success message pushes OK/Cancel buttons off the bottom
Severity: normal → trivial
See also attachment 424880 [details] on bug 543866. It also exhibits this bug, but with an error message instead of a success message.
Depends on: 545725
Keywords: polish
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Future
This should be fixed as a part of bug 545725. Please test using 1.2b3? Definitely fixed on Mac...
This can be bad in the error-requiring-further-action case, not a hard blocker but on radar for 1.3.
Assignee: nobody → mconnor
Severity: trivial → minor
Target Milestone: Future → 1.3
Flags: blocking-weave1.3+
(In reply to comment #5) > This should be fixed as a part of bug 545725. Please test using 1.2b3? Sorry, just noticed this comment now. I re-tested with Weave 1.2.1 (on a m-c nightly in Ubuntu 10.04 beta), with these results: (A) change-password dialog: fixed (B) change-passphrase dialog: Still broken, but the brokenness is earlier now. When I type the first character in either of the textboxes, the "Cancel"/"Change Secret Phrase" buttons immediately jump down a few pixels. (and they stay shifted-down until I complete the dialog) Should I file a new bug on that?
Here's a screenshot of the broken change-passphrase dialog, after I've typed a single character into one of the textboxes. The buttons are moved downwards. NOTE: Unlike in comment 0, no text has appeared to "push" the buttons off the dialog. However, if I type out my exact current secret phrase, I do see this message appear: "The secret phrase cannot be the same as your current secret phrase." Perhaps that message gets invisibly inserted when I type the first character, and that pushes the buttons off-dialog?
Attachment #439078 - Attachment description: newer screenshot (Weave 1.2.1), change-passophrase dialog → newer screenshot (Weave 1.2.1), change-passphrase dialog
Attachment #439078 - Attachment description: newer screenshot (Weave 1.2.1), change-passphrase dialog → newer screenshot (Weave 1.2.1), change-passphrase dialog [BROKEN]
Here's the dialog with my exact secret phrase entered, so the > The secret phrase cannot be the same as your current secret phrase. message is displayed (as described in previous comment)
...and here's the change-passphrase dialog before I've typed anything. From alt-tabbing between this and the previous attachment (with "cannot be the same" message), it looks like my suspicion at the end of comment 8 is correct -- the "cannot be the same" message overlaps some of the space that was originally occupied by the displaced buttons.
Whiteboard: [b2]
Whiteboard: [b2]
Target Milestone: 1.3 → 1.3b3
Attached patch v1 (deleted) — Splinter Review
Attachment #441947 - Flags: review?(edilee)
Attachment #441947 - Flags: review?(edilee) → review+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
verified on windows too with 1.3b3
Status: RESOLVED → VERIFIED
Verified on Linux that the outstanding issue from Comment 7 is fixed, with 1.3b3. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100503 Minefield/3.7a5pre
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: