Closed
Bug 543858
Opened 15 years ago
Closed 15 years ago
Weave's change-password/passphrase dialogs allow me to leave password/passphrase unchanged
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
1.2
People
(Reporter: dholbert, Assigned: Mardak)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE:
1. In Weave Preferences, click "Manage Account"
2. Click "Change Password" (or "Change Secret Phrase")
3. Complete the dialog, typing your existing password (or passphrase) in each dialog.
EXPECTED RESULTS:
The dialog should alert me that my new password (or passphrase) must be different from my old one.
ACTUAL RESULTS:
Weave says "Your password has been changed." (as in attachment 424874 [details]) and
ignores the fact that nothing's actually changed.
JUSTIFICATION OF EXPECTED RESULTS:
If a user chooses to open & fill out the "change password/passphrase" dialog, that presumably means they *want* to change it -- they're probably not intending to keep it the same. And if they change their mind and *decide* to keep it the same, "Cancel" is still available for them to press.
|
Reporter | |
Comment 1•15 years ago
|
||
I'm using:
Weave Sync 1.0
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100202
Minefield/3.7a1pre
Ubuntu 9.10 (Karmic)
|
|
Reporter | |
Updated•15 years ago
|
Summary: Weave's change-password/passphrase dialogs allow me to leave password unchanged → Weave's change-password/passphrase dialogs allow me to leave password/passphrase unchanged
|
||
Updated•15 years ago
|
|
|
||
Updated•15 years ago
|
Target Milestone: --- → 1.3
|
|
||
Updated•15 years ago
|
Assignee: nobody → mconnor
Flags: blocking-weave1.3+
|
Assignee | |
Comment 2•15 years ago
|
||
A separate issue is that the warning stays there even after the password/secret becomes valid.
|
|
||
Updated•15 years ago
|
Attachment #437432 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/88391959b484
Check if the new value is the same as the current one and provide a warning.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: 1.3 → 1.2
|
||
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•