Closed
Bug 544333
Opened 15 years ago
Closed 15 years ago
[OS/2] update include path for resource compiler
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a2
People
(Reporter: wuno, Assigned: wuno)
References
Details
Attachments
(2 files)
(deleted),
patch
|
wuno
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
wuno
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a1pre) Gecko/20100204 Minefield/3.7a1pre
Build Identifier:
Since firefox is build libxul enabled by default and seamonkey is a shared build and thunderbird was built on top of mozilla-1.9.1, I've got aware of this bug only yesterday when I tried to build thunderbird from c-c on top of m-c for the first time. The header directory in dist was flattened. We have to adjust the include path for the resource compiler for static builds It fails to find dist/include/widget
Reproducible: Always
Assignee | ||
Comment 1•15 years ago
|
||
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #425274 -
Flags: review?(daveryeo)
I don't have permission to r+ as both attachments deserve.
I never came across this bug as I usually build Thunderbird etc shared.
Assignee | ||
Comment 4•15 years ago
|
||
Comment on attachment 425274 [details] [diff] [review]
for c-c tb sm sb
[Checkin: Comment 6]
Set to r+ after approval from Dave in comment #3
Attachment #425274 -
Flags: review?(daveryeo) → review+
Assignee | ||
Comment 5•15 years ago
|
||
Comment on attachment 425273 [details] [diff] [review]
for m-c
[Checkin: Comment 7]
Set to r+ after approval from Dave in comment #3
Attachment #425273 -
Flags: review?(daveryeo) → review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: attachment 425273
Comment 6•15 years ago
|
||
Comment on attachment 425274 [details] [diff] [review]
for c-c tb sm sb
[Checkin: Comment 6]
http://hg.mozilla.org/comm-central/rev/27334ef4b0be
Attachment #425274 -
Attachment description: for c-c tb sm sb → for c-c tb sm sb
[Checkin: Comment 6]
Updated•15 years ago
|
Flags: in-testsuite-
Comment 7•15 years ago
|
||
Comment on attachment 425273 [details] [diff] [review]
for m-c
[Checkin: Comment 7]
http://hg.mozilla.org/mozilla-central/rev/cf63181a4e51
Attachment #425273 -
Attachment description: for m-c → for m-c
[Checkin: Comment 7]
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: attachment 425273 → [T.M. = mozilla1.9.3b1]
Target Milestone: --- → mozilla1.9.3
Assignee | ||
Comment 8•15 years ago
|
||
(In reply to comment #7)
> (From update of attachment 425273 [details] [diff] [review])
>
Serge, for getting this in mozilla-1.9.2 you think I have to ask for approval from drivers? In principle, we have a+ for OS/2-only patches for all trees as they are NPOTB. However, though only in an ifdef XP_OS2 section this is in cross-platform file. On the other hand I don't want to bother drivers with such trivial patches that won't interfere with tier_1 platforms.
Updated•15 years ago
|
Whiteboard: [T.M. = mozilla1.9.3b1]
Target Milestone: mozilla1.9.3 → mozilla1.9.3a2
Comment 9•15 years ago
|
||
(In reply to comment #8)
> we have a+ for OS/2-only patches for all trees as they are NPOTB.
I assume that's enough.
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•