Closed Bug 54452 Opened 24 years ago Closed 23 years ago

ubercaret after deleting part of quoted text

Categories

(Core :: DOM: Editor, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: akkzilla, Assigned: mozeditor)

References

Details

(Keywords: regression, Whiteboard: [behavior][QAHP] fix in hand (by bug 67847))

Reply to a plaintext message in html compose. Split the quote somewhere and type something. Now use the mouse to select from the beginning of the second quoted block (right after your new text) a few lines down into the quote, and hit delete. You'll get an ubercaret every time. This is one of the most common operations in replying to mail, so it's a bad place to lose the selection.
Keywords: rtm
Oops, not "every time". Dragging the selection down the left side of the quote (i.e. deleting full lines, not partial lines) seems to make it more likely.
if this is rtm, then im setting it to m19. anthonyd
Target Milestone: --- → M19
Blocks: 54449
No longer blocks: 54449
Joe: I was looking at the nsHTMLEditRules::WillDeleteSelection code because of bug 54449, and I noticed that at the end, it collapses to either the start or the end node. But what if that node is gone because it's a text node and we've just deleted all the text inside it? Could that be what's happening here? I typically see it when I'm deleting collections of whole lines (which means whole text nodes, since quoted plaintext retains its line breaks and they're turned into <br> tags).
joe, how diificult will this be to fix? how risky will the fix be? how much effort will it take to get this resolved?
Whiteboard: awaiting eval
Blocks: 54449
I checked in a workaround for 54449, which avoids this bug but has the side effect of disabling delete-to-end-of-line when on a blank line or at the end of a line (it should delete forward) by changing eNext to eNone. See the comment containing this bug id. When this bug is fixed, please also revert this workaround and set the eNone back to eNext so that delete-to-end will work fully again. Thanks! Note to PDT regarding severity: this is a very common action to do in editing email replies. I usually do this at least a couple times per message, in every reply I make. With this bug, I have to do some up/down arrowing and line-deleting in order to get the caret back where it needs to be after each time I delete part of the quoted material. It makes html mail compose a big hassle to use.
marking rtm- and setting to future
Whiteboard: awaiting eval → [rtm-]
Target Milestone: M19 → Future
moz 0.9
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9
moving a bunch of 0.9 bugs to 0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
Whiteboard: [rtm-] → [rtm-] [QAHP]
Target Milestone: mozilla0.9.1 → mozilla0.9.2
need to retest and reconfirm issue
Blocks: 78239
Akkana, you can still get this to happen?
See my last comment: the workaround is preventing this from happening, but it's causing a different bug (marked as depending on this one).
Whiteboard: [rtm-] [QAHP] → [behavior][rtm-] [QAHP]
Keywords: rtm
Whiteboard: [behavior][rtm-] [QAHP] → [behavior][QAHP]
fixed by patch in 67847.
Whiteboard: [behavior][QAHP] → [behavior][QAHP] fix in hand
Whiteboard: [behavior][QAHP] fix in hand → [behavior][QAHP] fix in hand (by bug 67847)
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Akkana, does this work for you now? thanks..
verified...doesn't happen for Akkana anymore...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.