Bug 539355 comment 16: { http://hg.mozilla.org/build/buildbot-configs/rev/3c518cc26451 Robert Kaiser — hrm, we can't support tests in nightly and release builds atm, as those are static, and building tests fails in that configuration :( }

Iiuc, this can be done now that bug 394502 is fixed, can't it?

This should allow us package and upload tests, as Firefox do. (Even if they are not automatically run.)

Av1, with explicit config for 'linux' too. Unexpectedly, 'linux' already had implicit --enable-tests :-|

Interesting: http://hg.mozilla.org/build/buildbot-configs/file/1bfaa46dd34c/seamonkey/config.py Indicates that all our Opt builds package-tests, and our debug builds don't. But this should fix us, aiui. Pushed: http://hg.mozilla.org/build/buildbot-configs/rev/55cecfc497da to get us green nightlies tonight [minus different OSX PPC issue]

(In reply to comment #4) > Indicates that all our Opt builds package-tests, and our debug builds don't. > But this should fix us, aiui. For posterity, looking a bit further shows the factory itself enables packageTests for debug.

(In reply to comment #4) > Indicates that all our Opt builds package-tests [...] > But this should fix us, aiui. Ftr, see bug 601113 comment 9 discussion.

And this patch is WRONG as --enable-tests is default and therefore should be LEFT OUT!

(In reply to comment #3) > Unexpectedly, 'linux' already had implicit --enable-tests :-| Oh, and that was not unexpected, this was fully intentional, but you guys didnt leave me time to r- the patch here :(

(In reply to comment #5) > (In reply to comment #4) > > Indicates that all our Opt builds package-tests, and our debug builds don't. > > But this should fix us, aiui. > > For posterity, looking a bit further shows the factory itself enables > packageTests for debug. Right, we actually run packaged tests there, which enables packaging them automatically anyhow.

(In reply to comment #7) > And this patch is WRONG as --enable-tests is default and therefore should be > LEFT OUT! Well not necessarily WRONG, just unnecessary. (In reply to comment #8) > (In reply to comment #3) > > Unexpectedly, 'linux' already had implicit --enable-tests :-| > > Oh, and that was not unexpected, this was fully intentional, but you guys didnt > leave me time to r- the patch here :( I wasn't sure how active you'd be in your first weekend in MV, so I didn't want to presume you would get to this, and I surely wanted nightlies running. [sorry]

(In reply to comment #7) > And this patch is WRONG as --enable-tests is default and therefore should be > LEFT OUT! In bug 539355, you wrote first "My target is to be as near as possible to Firefox configs" then "we probably will remove explicit --enable-tests completely in the end, the fewer options in mozconfig, the better" (which are somewhat contradictory, initially) As Firefox and our other builds do have explicit '--enable-tests', I chose the former solution. (In reply to comment #8) > Oh, and that was not unexpected, this was fully intentional, but you guys didnt > leave me time to r- the patch here :( Maybe "fully intentional", but not self-explaining why 'linux' only, especially when removal was _silently_ merged into bug 599530 (check-in)! And I did request review from you, exactly for all these points.!. *** Then, this patch did fix what we wanted and didn't break anything, afaik. So, a much nicer comment would have been to just say that you preferred to make this option implicit from now on and ask me to simply do that (afterward). Do you want me to do the latter now? *** V.Fixed per /pub/seamonkey/nightly/2010/10/2010-10-03-01-comm-central-trunk seamonkey-2.1b1pre.en-US.win32.tests.zip

Forget it, I don't have time for useless debates.