Closed Bug 54520 Opened 24 years ago Closed 24 years ago

Extra carriage return with bullets

Categories

(Core :: DOM: Editor, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: bijals, Assigned: mozeditor)

References

Details

(Whiteboard: [list] fix in hand, need a=)

Steps:
1) Open a blank Composer document
2) Type "asdf"
3) Put caret in between "a" and "s" and hit return
4) Click the bullet icon several times

Actual Results: Get all these carriage returns and caret in front of bullet.

Expected Results: Caret moves to bullet and clicking bullet icon multiple times
does not add carriage returns

Build Date/Platform: 2000092808 using NT
Strange list behavior! Hopefully, not a really common pattern. Setting to 
future.
Assignee: beppe → jfrancis
Target Milestone: --- → Future
hmmm... I thought I had stamped all these out.  I bet we can fix for rtm.  Beth, 
will you nominate?
Status: NEW → ASSIGNED
moz 0.9
Target Milestone: Future → mozilla0.9
appeasing bug gods
Target Milestone: mozilla0.9 → mozilla0.9.1
Blocks: 77421
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Whiteboard: [list]
Keywords: correctness
*** Bug 83158 has been marked as a duplicate of this bug. ***
fixed by patch in 54539
Whiteboard: [list] → [list] fix in hand
need a=
Whiteboard: [list] fix in hand → [list] fix in hand, need a=
a=blizzard on behalf of drivers for the trunk
so I see this problem with the current fix:
  overeager removal of br's

to reproduce:
 * Create Composer document that looks like this:
Aasdf
Basdf
Casdf
Dasdf
Easdf
 * place the caret before "Basdf"
 * click the bullet list icon
 * click the bullet list icon again
Notice that "Casdf" is now on the same line with Basdf
 * click the bullet list icon a few more times
Notice that all of the lines (after the first line) become one line
Joe, the bug that brade points out is happening because PopList pushes the list 
item at the beginning of the list, in front of the list, so when you try to 
unwrap the contents of the list item with a call to RemoveBlockContainer() it 
fails to add a BR because the list item is followed by a "block", which in this 
case is the list it was moved out of.
thanks kathy, kin.  i think i fixed that over the weekend but didnt update my
patch.  I'll make sure I fix it for landing.
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
the carriage returns are fixed...but I still get caret in front of bullet.

filing new bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.