Closed
Bug 545341
Opened 15 years ago
Closed 15 years ago
Remove unneeded xpfe autocomplete code.
Categories
(Camino Graveyard :: Location Bar & Autocomplete, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chris, Assigned: chris)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
Dan's work has removed our reliance on xpfe autocomplete. The only vestiges are the class declarations in AutoCompleteTextField.h. We can remove them safely for 2.1.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → trendyhendy2000
Status: NEW → ASSIGNED
Attachment #426186 -
Flags: superreview?(stuart.morgan+bugzilla)
|
|
Assignee | |
Comment 2•15 years ago
|
||
The scope for this bug has increased. The next patch will also remove things from nsStaticComponents and the Xcode project.
Blocks: 383085
Summary: Remove unneeded class declarations in AutoCompleteTextField → Remove unneeded xpfe autocomplete code.
|
|
Assignee | |
Comment 3•15 years ago
|
||
Sorry about the extra bugmails. This is the actual fix. Removes class declarations from AutoCompleteTextField, entry in nsStaticComponents, and library references in the Xcode project.
Attachment #426186 -
Attachment is obsolete: true
Attachment #426191 -
Flags: superreview?(stuart.morgan+bugzilla)
Attachment #426186 -
Flags: superreview?(stuart.morgan+bugzilla)
|
||
Comment 4•15 years ago
|
||
Comment on attachment 426191 [details] [diff] [review]
Fix v1.1
sr=smorgan (yay code removal!)
The only caveat is that nsSimpleGlobalHistory still uses autocomplete stuff, so I assume this version of the patch is dependent on the places history patch landing first.
Attachment #426191 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
(In reply to comment #4)
> (From update of attachment 426191 [details] [diff] [review])
> sr=smorgan (yay code removal!)
>
> The only caveat is that nsSimpleGlobalHistory still uses autocomplete stuff, so
> I assume this version of the patch is dependent on the places history patch
> landing first.
Oops, that's my fault; I told hendy we needed to remove the libraries and nsStaticComponents stuff, too, so it didn't get left around, but it was very late and I'd forgotten nsSimpleGlobalHistory was still here on 1.9.0 :P
|
|
||
Comment 6•15 years ago
|
||
sr=me on landing just the camino/src/browser/AutoCompleteTextField.h part now if you like.
Depends on: 351351
(In reply to comment #6)
> sr=me on landing just the camino/src/browser/AutoCompleteTextField.h part now
> if you like.
Landed the AutoCompleteTextField.h hunk on cvs trunk.
Landed the rest of the patch on cvs trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•