Now that fielddefs has a "buglist" column, colchange should be getting its information from the database instead of having a static list.

This turned out to be very easy. :-)

Comment on attachment 427023 [details] [diff] [review] v1 >=== modified file 'colchange.cgi' >+use constant COLUMN_PARAMS => { 'usestatuswhiteboard' is missing. >+foreach my $param (keys %{ COLUMN_PARAMS() }) { >+ foreach my $column (@{ COLUMN_PARAMS->{$param} }) { >+ delete $columns->{$column} if !Bugzilla->params->{$param}; >+ } >+} This would be cleaner and more logical as: foreach my $param (keys %{ COLUMN_PARAMS() }) { next if Bugzilla->params->{$param}; foreach my $column (@{ COLUMN_PARAMS->{$param} }) { delete $columns->{$column}; } } This way, you check Bugzilla->params->{$param} only once per parameter. >+foreach my $class (keys %{ COLUMN_CLASSES() }) { >+ eval("use $class"); This eval() is useless. Also, the column list in colchange.cgi is now random and pretty confusing. For now, I think it should just be sorted alphabetically. Otherwise looks good and works fine.

Thanks for catching all that stuff. I kept the eval(use) in there, because I don't know if the other modules will keep "use"ing Bugzilla::Keyword and Bugzilla::Flag, so we should explicitly use them here just in case. Also, I realized that "relevance" needed to be excluded from the column list, so I did. I'm sorting the available columns case-sensitively and alphabetically now. I changed the name of the "Full Summary" column so that it sorts together with the short summary column. I also changed the names of the realname columns, to re-use the field_descs values properly and also to put a space in "Real Name".

Comment on attachment 432778 [details] [diff] [review] v2 r=LpSolit

I forgot to mark this resolved when I did the checkin. revision 7070 modified: Bugzilla/Hook.pm colchange.cgi template/en/default/list/change-columns.html.tmpl