http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1265531400.1265537595.19916.gz&fulltext=1 Linux comm-central-trunk nightly on 2010/02/07 00:30:00 { make package-compare -bin/components/libunixproxy.so } It looks like it lost its '#ifndef MOZ_STATIC_BUILD'.

Comment on attachment 444459 [details] [diff] [review] (Av1) Fix regression, Group related files [Checkin: See comment 5] >+ #ifdef XP_WIN Preprocessor can't interpret with spaces preceding this. Also, please simply fix the regression here than trying (again!) to reorder stuff.

(In reply to comment #2) > Preprocessor can't interpret with spaces preceding this. Oh? What error do you get? > Also, please simply fix the regression here than trying (again!) to reorder > stuff. Why not group these files as other related ones are?

Comment on attachment 444459 [details] [diff] [review] (Av1) Fix regression, Group related files [Checkin: See comment 5] OK, but please don't change the indentation in this patch. Either we change it everywhere in this file (at once) or nowhere, but please not for some parts and not for the rest.

Comment on attachment 444459 [details] [diff] [review] (Av1) Fix regression, Group related files [Checkin: See comment 5] http://hg.mozilla.org/comm-central/rev/b71ecabf4d40 Av1, with comment 4 suggestion(s).