Closed
Bug 546300
Opened 15 years ago
Closed 15 years ago
Octal Numeric Constants are deprecated
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b2
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Taraman
:
review+
|
Details | Diff | Splinter Review |
On Trunk I recently got a few warnings, that Octal Numeric Constants are deprecated. Seems it has been this way for a few JS versions, but now its really going to go away. I think we should use parseInt to convert the octal string to a number, since converting to a decimal or hex number can be a bit confusing if you expect a file mode.
This patch takes care.
Attachment #426985 -
Flags: review?(Mozilla)
|
||
Updated•15 years ago
|
Attachment #426985 -
Flags: review?(Mozilla) → review+
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 426985 [details] [diff] [review]
Fix - v1
Looks good.
As far as I could see this patch cought all occurrences.
r=Markus
|
Assignee | |
Comment 2•15 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a09d93441f7d>
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0b2
You need to log in
before you can comment on or make changes to this bug.
Description
•