Closed Bug 547257 Opened 15 years ago Closed 15 years ago

mdimporter 'MODULE' is defined too late

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird3.0 .4-fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.1b1
Tracking Flags:
Tracking Status
thunderbird3.0 --- .4-fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(
URL
)

Details

Attachments

(1 file)

(Av1) Move it before rules.mk [Checkin: Comment 4 & 5]
(deleted), patch
standard8
: review+
standard8
: approval-thunderbird3.0.4+
Details | Diff | Splinter Review
{ http://build.mozillamessaging.com/buildbot/try/builders/Try%20server%20comm-central%20mac%20hg%20builder/builds/369/steps/building/logs/stdio creating mail/components/search/mdimporter/Makefile /Volumes/Build/sendchange-mac-hg/mozilla/config/rules.mk:2223: *** Makefile variable 'MODULE' changed value after including rules.mk. Was '', now mdimporter.. Stop. make[6]: *** [export] Error 2 } I manually checked that this is the only case in c-c.
Flags: in-testsuite-
Please, check if anything else should move up too.
Attachment #427784 - Flags: review?(bugzilla)
Comment on attachment 427784 [details] [diff] [review] (Av1) Move it before rules.mk [Checkin: Comment 4 & 5] This looks fine, afaict nothing else needs moving (compared with another similar Makefile.in)
Attachment #427784 - Flags: review?(bugzilla) → review+
Comment on attachment 427784 [details] [diff] [review] (Av1) Move it before rules.mk [Checkin: Comment 4 & 5] "approval-thunderbird3.0.3=?": Zero risk, build config only.
Attachment #427784 - Attachment description: (Av1) Move it before rules.mk → (Av1) Move it before rules.mk [Checkin: Comment 3]
Attachment #427784 - Flags: approval-thunderbird3.0.3?
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 427784 [details] [diff] [review] (Av1) Move it before rules.mk [Checkin: Comment 4 & 5] http://hg.mozilla.org/comm-central/rev/23896dd2b875
Attachment #427784 - Attachment description: (Av1) Move it before rules.mk [Checkin: Comment 3] → (Av1) Move it before rules.mk [Checkin: Comment 4]
Attachment #427784 - Flags: approval-thunderbird3.0.3? → approval-thunderbird3.0.4?
Attachment #427784 - Flags: approval-thunderbird3.0.4? → approval-thunderbird3.0.4+
Comment on attachment 427784 [details] [diff] [review] (Av1) Move it before rules.mk [Checkin: Comment 4 & 5] http://hg.mozilla.org/releases/comm-1.9.1/rev/55d0dea42a80
Attachment #427784 - Attachment description: (Av1) Move it before rules.mk [Checkin: Comment 4] → (Av1) Move it before rules.mk [Checkin: Comment 4 & 5]
Verified on the basis this landed and hasn't broken anything.
Keywords: verified-thunderbird3.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: